Method getReturnTypeOverridesStatic has 109 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private static function getReturnTypeOverridesStatic(): array
    {
        /**
         * @param list<Node|int|string|float> $args
         */

Function getReturnTypeOverridesStatic has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.

Open

    private static function getReturnTypeOverridesStatic(): array
    {
        /**
         * @param list<Node|int|string|float> $args
         */

• Read up
  Read up

The class ClosureReturnTypeOverridePlugin has an overall complexity of 53 which is very high. The configured complexity threshold is 50.

Open

final class ClosureReturnTypeOverridePlugin extends PluginV3 implements
    AnalyzeFunctionCallCapability,
    ReturnTypeOverrideCapability
{

• Exclude checks
  • Disable engine
  • Disable check

File ClosureReturnTypeOverridePlugin.php has 281 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

declare(strict_types=1);

namespace Phan\Plugin\Internal;

Function resetReferenceArgumentsTypes has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.

Open

    private static function resetReferenceArgumentsTypes(CodeBase $code_base, Context $context, $arg_array_node): void
    {
        if (!($arg_array_node instanceof Node) || $arg_array_node->kind !== \ast\AST_ARRAY) {
            return;
        }

• Read up
  Read up

Method getAnalyzeFunctionCallClosuresStatic has 44 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private static function getAnalyzeFunctionCallClosuresStatic(): array
    {
        /**
         * @param list<Node|int|string|float> $args
         */

Function extractArrayArgs has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

    private static function extractArrayArgs($arg_array_node)
    {
        if (($arg_array_node instanceof Node) && $arg_array_node->kind === \ast\AST_ARRAY) {
            $arguments = [];
            foreach ($arg_array_node->children as $child) {

• Read up
  Read up

Avoid too many return statements within this method.

Open

                return $element_types;

Avoid too many return statements within this method.

Open

                    return $type->hasKnownFQSEN();

Avoid too many return statements within this method.

Open

            return $types->withRealTypeSet(UnionType::typeSetFromString('\Closure|false|null'));

Avoid too many return statements within this method.

Open

                return NullType::instance(false)->asRealUnionType();

Avoid too many return statements within this method.

Open

            return $element_types;

Avoid too many return statements within this method.

Open

            return $closure_types->withRealType(ClosureType::instance(false));

Avoid too many return statements within this method.

Open

        return [
            // call
            'call_user_func'            => $call_user_func_callback,
            'forward_static_call'       => $call_user_func_callback,
            'call_user_func_array'      => $call_user_func_array_callback,

Avoid too many return statements within this method.

Open

        return [
            // call
            'call_user_func'            => $call_user_func_callback,
            'forward_static_call'       => $call_user_func_callback,
            'call_user_func_array'      => $call_user_func_array_callback,

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                return ClosureType::instance(false)->asRealUnionType();

Avoid too many return statements within this method.

Open

                return;

Avoid too many return statements within this method.

Open

                return NullType::instance(false)->asRealUnionType();

Avoid too many return statements within this method.

Open

                return UnionType::fromFullyQualifiedPHPDocAndRealString('\Closure', '\Closure|false|null');

The method getReturnTypeOverridesStatic() has an NPath complexity of 331776. The configured NPath complexity threshold is 200.

Open

    private static function getReturnTypeOverridesStatic(): array
    {
        /**
         * @param list<Node|int|string|float> $args
         */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method getReturnTypeOverridesStatic() has 135 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    private static function getReturnTypeOverridesStatic(): array
    {
        /**
         * @param list<Node|int|string|float> $args
         */

• Exclude checks
  • Disable engine
  • Disable check

The method getReturnTypeOverridesStatic() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.

Open

    private static function getReturnTypeOverridesStatic(): array
    {
        /**
         * @param list<Node|int|string|float> $args
         */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The class ClosureReturnTypeOverridePlugin has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.

Open

final class ClosureReturnTypeOverridePlugin extends PluginV3 implements
    AnalyzeFunctionCallCapability,
    ReturnTypeOverrideCapability
{

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Avoid variables with short names like $_. Configured minimum length is 3.

Open

            ?Node $_

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $i. Configured minimum length is 3.

Open

        return static function ($argument, int $i) use ($code_base, $context, &$cache): UnionType {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $el. Configured minimum length is 3.

Open

                $el = $child->children['value'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}