Method getReturnTypeOverridesStatic has 297 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static function getReturnTypeOverridesStatic(CodeBase $code_base): array
    {
        $string_union_type = StringType::instance(false)->asPHPDocUnionType();
        $string_union_type_real = StringType::instance(false)->asRealUnionType();
        $string_union_type_with_false_in_real = UnionType::fromFullyQualifiedPHPDocAndRealString('string', 'string|false');

Function getReturnTypeOverridesStatic has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.

Open

    public static function getReturnTypeOverridesStatic(CodeBase $code_base): array
    {
        $string_union_type = StringType::instance(false)->asPHPDocUnionType();
        $string_union_type_real = StringType::instance(false)->asRealUnionType();
        $string_union_type_with_false_in_real = UnionType::fromFullyQualifiedPHPDocAndRealString('string', 'string|false');

• Read up
  Read up

File DependentReturnTypeOverridePlugin.php has 362 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

declare(strict_types=1);

namespace Phan\Plugin\Internal;

The class DependentReturnTypeOverridePlugin has an overall complexity of 59 which is very high. The configured complexity threshold is 50.

Open

final class DependentReturnTypeOverridePlugin extends PluginV3 implements
    ReturnTypeOverrideCapability
{
    /**
     * A static method to compute the return type override methods

• Exclude checks
  • Disable engine
  • Disable check

Avoid too many return statements within this method.

Open

            return static function (
                CodeBase $unused_code_base,
                Context $unused_context,
                Func $unused_function,
                array $args

Avoid too many return statements within this method.

Open

            return $has_array ? $str_array_type : $str_replace_types;

Avoid too many return statements within this method.

Open

                return LiteralIntType::instanceForValue(count($arg->getFieldTypes()), false)->asRealUnionType();

Avoid too many return statements within this method.

Open

                    return $string_union_type_with_null_in_real;

Avoid too many return statements within this method.

Open

                    return NullType::instance(false)->asPHPDocUnionType();

Avoid too many return statements within this method.

Open

                return $json_decode_array_types;

Avoid too many return statements within this method.

Open

                return $json_decode_array_or_object_types;

Avoid too many return statements within this method.

Open

                    return $string_union_type_real;

Avoid too many return statements within this method.

Open

                return NullType::instance(false)->asRealUnionType();

Avoid too many return statements within this method.

Open

            return UnionType::fromFullyQualifiedPHPDocAndRealString(
                'non-empty-list<string>',
                $is_php8 ? 'non-empty-list<string>' : '?non-empty-list<string>'
            );

Avoid too many return statements within this method.

Open

            return $function->getUnionType();

Avoid too many return statements within this method.

Open

            return ($options_result & \JSON_OBJECT_AS_ARRAY) !== 0 ? $json_decode_array_types : $json_decode_object_types;

Avoid too many return statements within this method.

Open

            return $nullable_string_union_type;

Avoid too many return statements within this method.

Open

                return UnionType::fromFullyQualifiedPHPDocString('array<string,string>');

Avoid too many return statements within this method.

Open

                return $string_union_type_with_false_in_real;

Avoid too many return statements within this method.

Open

                    return $string_union_type_with_null_in_real;

Avoid too many return statements within this method.

Open

                return $json_decode_object_types;

Avoid too many return statements within this method.

Open

                return $str_replace_types;

Avoid too many return statements within this method.

Open

                        return $real_int_type;

Avoid too many return statements within this method.

Open

            return Type::fromObject($result)->asPHPDocUnionType();

Avoid too many return statements within this method.

Open

                return $has_array ? $str_replace_types : $string_union_type;

Avoid too many return statements within this method.

Open

                return $string_union_type_with_false_in_real;

Avoid too many return statements within this method.

Open

            return $real_int_type;

Avoid too many return statements within this method.

Open

            return $string_or_false;

Avoid too many return statements within this method.

Open

                return LiteralIntType::instanceForValue(2, false)->asRealUnionType();

Avoid too many return statements within this method.

Open

                    return UnionType::fromFullyQualifiedPHPDocAndRealString(
                        'list<string>',
                        $is_php8 ? 'list<string>' : '?list<string>'
                    );

Avoid too many return statements within this method.

Open

                return $real_int_type;

Avoid too many return statements within this method.

Open

                return StringType::instance(false)->asRealUnionType();

Avoid too many return statements within this method.

Open

            return $string_or_false;

Avoid too many return statements within this method.

Open

                return $real_int_type;

Avoid too many return statements within this method.

Open

                return $json_decode_array_or_object_types;

Avoid too many return statements within this method.

Open

                        return StringType::instance(false)->asRealUnionType();

Avoid too many return statements within this method.

Open

        return [
            // commonly used functions where the return type depends on a passed in boolean
            'var_export'                  => $string_if_2_true,
            'print_r'                     => $string_if_2_true_else_true,
            'json_decode'                 => $json_decode_return_type_handler,

Avoid too many return statements within this method.

Open

                return $json_decode_object_types;

Avoid too many return statements within this method.

Open

                return $string_union_type_with_null_in_real;

The method getReturnTypeOverridesStatic() has an NPath complexity of 361184624640. The configured NPath complexity threshold is 200.

Open

    public static function getReturnTypeOverridesStatic(CodeBase $code_base): array
    {
        $string_union_type = StringType::instance(false)->asPHPDocUnionType();
        $string_union_type_real = StringType::instance(false)->asRealUnionType();
        $string_union_type_with_false_in_real = UnionType::fromFullyQualifiedPHPDocAndRealString('string', 'string|false');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method getReturnTypeOverridesStatic() has 375 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    public static function getReturnTypeOverridesStatic(CodeBase $code_base): array
    {
        $string_union_type = StringType::instance(false)->asPHPDocUnionType();
        $string_union_type_real = StringType::instance(false)->asRealUnionType();
        $string_union_type_with_false_in_real = UnionType::fromFullyQualifiedPHPDocAndRealString('string', 'string|false');

• Exclude checks
  • Disable engine
  • Disable check

The method getReturnTypeOverridesStatic() has a Cyclomatic Complexity of 54. The configured cyclomatic complexity threshold is 10.

Open

    public static function getReturnTypeOverridesStatic(CodeBase $code_base): array
    {
        $string_union_type = StringType::instance(false)->asPHPDocUnionType();
        $string_union_type_real = StringType::instance(false)->asRealUnionType();
        $string_union_type_with_false_in_real = UnionType::fromFullyQualifiedPHPDocAndRealString('string', 'string|false');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The class DependentReturnTypeOverridePlugin has a coupling between objects value of 19. Consider to reduce the number of dependencies under 13.

Open

final class DependentReturnTypeOverridePlugin extends PluginV3 implements
    ReturnTypeOverrideCapability
{
    /**
     * A static method to compute the return type override methods

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}