Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Plugin/Internal/ExtendedDependentReturnTypeOverridePlugin.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method getReturnTypeOverridesStatic has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function getReturnTypeOverridesStatic(CodeBase $code_base): array
    {
        $basic_return_type_overrides = (new DependentReturnTypeOverridePlugin())->getReturnTypeOverrides($code_base);
        /**
         * @param callable-string $function
Severity: Major
Found in src/Phan/Plugin/Internal/ExtendedDependentReturnTypeOverridePlugin.php - About 2 hrs to fix

    Method wrapNArgumentFunction has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function wrapNArgumentFunction(
        string $function_name,
        int $min_args,
        ?int $max_args = null
    ): Closure {
    Severity: Minor
    Found in src/Phan/Plugin/Internal/ExtendedDependentReturnTypeOverridePlugin.php - About 1 hr to fix

      Function wrapNArgumentFunction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function wrapNArgumentFunction(
        string $function_name,
        int $min_args,
        ?int $max_args = null
    ): Closure {
      Severity: Minor
      Found in src/Phan/Plugin/Internal/ExtendedDependentReturnTypeOverridePlugin.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid excessively long class names like ExtendedDependentReturnTypeOverridePlugin. Keep class name length under 40.
      Open

      final class ExtendedDependentReturnTypeOverridePlugin extends PluginV3 implements
    ReturnTypeOverrideCapability
{
    /**
     * Given the name of a pure function with no side effects,
      Severity: Minor
      Found in src/Phan/Plugin/Internal/ExtendedDependentReturnTypeOverridePlugin.php by phpmd

      LongClassName

      Since: 2.9

      Detects when classes or interfaces are declared with excessively long names.

      Example

      class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

      Source https://phpmd.org/rules/naming.html#longclassname

      Avoid variables with short names like $cb. Configured minimum length is 3.
      Open

                  $cb = self::wrapNArgumentFunction($function, $min, $max);
      Severity: Minor
      Found in src/Phan/Plugin/Internal/ExtendedDependentReturnTypeOverridePlugin.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      There are no issues that match your filters.

      Category
      Status