src/Phan/Plugin/Internal/LoopVariableReuseVisitor.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function extractVariables has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function extractVariables($node): array
    {
        if (!$node instanceof Node) {
            return [];
        }
Severity: Minor
Found in src/Phan/Plugin/Internal/LoopVariableReuseVisitor.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method findVariableReuse has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function findVariableReuse(array $variables): void
    {
        if (!$variables) {
            return;
        }
Severity: Minor
Found in src/Phan/Plugin/Internal/LoopVariableReuseVisitor.php - About 1 hr to fix

    Method extractVariables has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function extractVariables($node): array
        {
            if (!$node instanceof Node) {
                return [];
            }
    Severity: Minor
    Found in src/Phan/Plugin/Internal/LoopVariableReuseVisitor.php - About 1 hr to fix

      Function findVariableReuse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          private function findVariableReuse(array $variables): void
          {
              if (!$variables) {
                  return;
              }
      Severity: Minor
      Found in src/Phan/Plugin/Internal/LoopVariableReuseVisitor.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $result;
      Severity: Major
      Found in src/Phan/Plugin/Internal/LoopVariableReuseVisitor.php - About 30 mins to fix

        The method extractVariables() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
        Open

            public function extractVariables($node): array
            {
                if (!$node instanceof Node) {
                    return [];
                }

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The method findVariableReuse() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
        Open

            private function findVariableReuse(array $variables): void
            {
                if (!$variables) {
                    return;
                }

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        There are no issues that match your filters.

        Category
        Status