Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Plugin/Internal/PhantasmPlugin/PhantasmVisitor.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method visitClassConst has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function visitClassConst(Node $node): void
    {
        if (!isset($node->tolerant_ast_node)) {
            return;
        }
Severity: Minor
Found in src/Phan/Plugin/Internal/PhantasmPlugin/PhantasmVisitor.php - About 1 hr to fix

    Function visitClassConst has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function visitClassConst(Node $node): void
    {
        if (!isset($node->tolerant_ast_node)) {
            return;
        }
    Severity: Minor
    Found in src/Phan/Plugin/Internal/PhantasmPlugin/PhantasmVisitor.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return;
    Severity: Major
    Found in src/Phan/Plugin/Internal/PhantasmPlugin/PhantasmVisitor.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in src/Phan/Plugin/Internal/PhantasmPlugin/PhantasmVisitor.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return;
        Severity: Major
        Found in src/Phan/Plugin/Internal/PhantasmPlugin/PhantasmVisitor.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return;
          Severity: Major
          Found in src/Phan/Plugin/Internal/PhantasmPlugin/PhantasmVisitor.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return;
            Severity: Major
            Found in src/Phan/Plugin/Internal/PhantasmPlugin/PhantasmVisitor.php - About 30 mins to fix

              Function isSafeNodeToSubstitute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function isSafeNodeToSubstitute(Context $context, $value_node): bool
    {
        if (!$value_node instanceof Node) {
            // TODO: floats might lose precision when converted back to strings by phantasm. Use the original expression based on the parent node?
            return \is_int($value_node) || \is_string($value_node);  // not null
              Severity: Minor
              Found in src/Phan/Plugin/Internal/PhantasmPlugin/PhantasmVisitor.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              The method visitClassConst() has an NPath complexity of 256. The configured NPath complexity threshold is 200.
              Open

                  public function visitClassConst(Node $node): void
    {
        if (!isset($node->tolerant_ast_node)) {
            return;
        }
              Severity: Minor
              Found in src/Phan/Plugin/Internal/PhantasmPlugin/PhantasmVisitor.php by phpmd

              NPathComplexity

              Since: 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example

              class Foo {
    function bar() {
        // lots of complicated code
    }
}

              Source https://phpmd.org/rules/codesize.html#npathcomplexity

              There are no issues that match your filters.

              Category
              Status