Method getAnalyzeFunctionCallClosuresStatic has 242 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private static function getAnalyzeFunctionCallClosuresStatic(): array
    {
        /**
         * @param Closure(UnionType):int $checker returns _IS_IMPOSSIBLE/_IS_REDUNDANT/_IS_REASONABLE_CONDITION
         * @param string $expected_type

File RedundantConditionCallPlugin.php has 291 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

declare(strict_types=1);

namespace Phan\Plugin\Internal;

Function getAnalyzeFunctionCallClosuresStatic has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    private static function getAnalyzeFunctionCallClosuresStatic(): array
    {
        /**
         * @param Closure(UnionType):int $checker returns _IS_IMPOSSIBLE/_IS_REDUNDANT/_IS_REASONABLE_CONDITION
         * @param string $expected_type

• Read up
  Read up

Avoid too many return statements within this method.

Open

                return self::_IS_IMPOSSIBLE;

Avoid too many return statements within this method.

Open

            return self::_IS_IMPOSSIBLE;

Avoid too many return statements within this method.

Open

            return self::_IS_REASONABLE_CONDITION;

Avoid too many return statements within this method.

Open

            return $union_type->isExclusivelyStringTypes();

Avoid too many return statements within this method.

Open

                return self::_IS_REDUNDANT;

Avoid too many return statements within this method.

Open

                return self::_IS_IMPOSSIBLE;

Avoid too many return statements within this method.

Open

                    return self::_IS_REDUNDANT;

Avoid too many return statements within this method.

Open

                return self::_IS_IMPOSSIBLE;

Avoid too many return statements within this method.

Open

                    return $type instanceof ArrayShapeType;

Avoid too many return statements within this method.

Open

            return self::_IS_REASONABLE_CONDITION;

Avoid too many return statements within this method.

Open

            return $union_type->intTypes()->isEqualTo($union_type);

Avoid too many return statements within this method.

Open

            return self::_IS_REASONABLE_CONDITION;

Avoid too many return statements within this method.

Open

                    return self::_IS_REASONABLE_CONDITION;

Avoid too many return statements within this method.

Open

                return self::_IS_REDUNDANT;

Avoid too many return statements within this method.

Open

            return $union_type->isExclusivelyBoolTypes();

Avoid too many return statements within this method.

Open

            return self::_IS_REASONABLE_CONDITION;

Avoid too many return statements within this method.

Open

                return self::_IS_IMPOSSIBLE;

Avoid too many return statements within this method.

Open

                return self::_IS_IMPOSSIBLE;

Avoid too many return statements within this method.

Open

                return self::_IS_REDUNDANT;

Avoid too many return statements within this method.

Open

        return [
            // 'is_a' => $is_a_callback,
            'is_array' => $array_callback,
            'is_bool' => $bool_callback,
            'is_callable' => $callable_callback,

Avoid too many return statements within this method.

Open

                    return self::_IS_REDUNDANT;

Avoid too many return statements within this method.

Open

                return self::_IS_REDUNDANT;

Avoid too many return statements within this method.

Open

                    return self::_IS_REASONABLE_CONDITION;

Avoid too many return statements within this method.

Open

            return $make_first_arg_checker(static function (UnionType $union_type) use ($condition): int {
                if (!$union_type->containsNullableOrUndefined() && $condition($union_type)) {
                    return self::_IS_REDUNDANT;
                }
                return self::_IS_REASONABLE_CONDITION;

Avoid too many return statements within this method.

Open

                return self::_IS_REDUNDANT;

Avoid too many return statements within this method.

Open

            return self::_IS_REASONABLE_CONDITION;

Avoid too many return statements within this method.

Open

                    return $type instanceof ArrayShapeType;

Avoid too many return statements within this method.

Open

                return self::_IS_REDUNDANT;

Avoid too many return statements within this method.

Open

                return self::_IS_IMPOSSIBLE;

Avoid too many return statements within this method.

Open

            return self::_IS_REASONABLE_CONDITION;

Avoid too many return statements within this method.

Open

                return self::_IS_IMPOSSIBLE;

Avoid too many return statements within this method.

Open

            return self::_IS_REASONABLE_CONDITION;

Avoid too many return statements within this method.

Open

            return $union_type->floatTypes()->isEqualTo($union_type);

The method getAnalyzeFunctionCallClosuresStatic() has an NPath complexity of 1216512. The configured NPath complexity threshold is 200.

Open

    private static function getAnalyzeFunctionCallClosuresStatic(): array
    {
        /**
         * @param Closure(UnionType):int $checker returns _IS_IMPOSSIBLE/_IS_REDUNDANT/_IS_REASONABLE_CONDITION
         * @param string $expected_type

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method getAnalyzeFunctionCallClosuresStatic() has 278 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    private static function getAnalyzeFunctionCallClosuresStatic(): array
    {
        /**
         * @param Closure(UnionType):int $checker returns _IS_IMPOSSIBLE/_IS_REDUNDANT/_IS_REASONABLE_CONDITION
         * @param string $expected_type

• Exclude checks
  • Disable engine
  • Disable check

The method getAnalyzeFunctionCallClosuresStatic() has a Cyclomatic Complexity of 36. The configured cyclomatic complexity threshold is 10.

Open

    private static function getAnalyzeFunctionCallClosuresStatic(): array
    {
        /**
         * @param Closure(UnionType):int $checker returns _IS_IMPOSSIBLE/_IS_REDUNDANT/_IS_REASONABLE_CONDITION
         * @param string $expected_type

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The class RedundantConditionCallPlugin has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13.

Open

final class RedundantConditionCallPlugin extends PluginV3 implements
    AnalyzeFunctionCallCapability,
    PostAnalyzeNodeCapability
{
    private const _IS_IMPOSSIBLE = 1;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Avoid variables with short names like $_. Configured minimum length is 3.

Open

            return static function (CodeBase $code_base, Context $context, FunctionInterface $unused_function, array $args, ?Node $_) use ($checker, $expected_type): void {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}