src/Phan/Plugin/Internal/RedundantConditionLoopCheck.php
The class RedundantConditionLoopCheck has an overall complexity of 53 which is very high. The configured complexity threshold is 50. Open
Open
class RedundantConditionLoopCheck
{
/**
* @param Node|int|float|string|null $cond_node
* @return associative-array<int|string,bool>- Exclude checks
Method extractIncrementDirections has 71 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function extractIncrementDirections(CodeBase $code_base, Context $context, $cond_node): array
{
if (!$cond_node instanceof Node) {
return [];
}Function extractIncrementDirections has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
Open
public static function extractIncrementDirections(CodeBase $code_base, Context $context, $cond_node): array
{
if (!$cond_node instanceof Node) {
return [];
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method extractComparisonDirectionsFromBinaryOp has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private static function extractComparisonDirectionsFromBinaryOp(Node $cond_node, bool $negate): array
{
['left' => $left_node, 'right' => $right_node] = $cond_node->children;
switch ($cond_node->flags) {
case flags\BINARY_IS_SMALLER:Function extractComparisonDirectionsFromBinaryOp has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
Open
private static function extractComparisonDirectionsFromBinaryOp(Node $cond_node, bool $negate): array
{
['left' => $left_node, 'right' => $right_node] = $cond_node->children;
switch ($cond_node->flags) {
case flags\BINARY_IS_SMALLER:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method extractIncrementDirectionForAssignOp has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
private static function extractIncrementDirectionForAssignOp(CodeBase $code_base, Context $context, string $var_name, $expr, bool $is_subtraction): arrayAvoid too many return statements within this method. Open
Open
return [];Avoid too many return statements within this method. Open
Open
return [];Avoid too many return statements within this method. Open
Open
return [];Avoid too many return statements within this method. Open
Open
return [];Avoid too many return statements within this method. Open
Open
return [];Avoid too many return statements within this method. Open
Open
return [];Avoid too many return statements within this method. Open
Open
return self::extractIncrementDirectionForAssignOp($code_base, $context, $var_name, $cond_node->children['expr'], $is_subtraction);Avoid too many return statements within this method. Open
Open
return [];Avoid too many return statements within this method. Open
Open
return [];Avoid too many return statements within this method. Open
Open
return self::extractIncrementDirectionForAssignOp($code_base, $context, $var_name, $operation->children['right'], $is_subtraction);Avoid too many return statements within this method. Open
Open
return [];Avoid too many return statements within this method. Open
Open
return $left_flags + $right_flags;Avoid too many return statements within this method. Open
Open
return self::extractIncrementDirectionForAssignOp($code_base, $context, $var_name, $operation->children['left'], $is_subtraction);Avoid too many return statements within this method. Open
Open
return [];The method extractIncrementDirections() has an NPath complexity of 458. The configured NPath complexity threshold is 200. Open
Open
public static function extractIncrementDirections(CodeBase $code_base, Context $context, $cond_node): array
{
if (!$cond_node instanceof Node) {
return [];
}- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method extractIncrementDirections() has a Cyclomatic Complexity of 23. The configured cyclomatic complexity threshold is 10. Open
Open
public static function extractIncrementDirections(CodeBase $code_base, Context $context, $cond_node): array
{
if (!$cond_node instanceof Node) {
return [];
}- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method extractComparisonDirectionsFromBinaryOp() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10. Open
Open
private static function extractComparisonDirectionsFromBinaryOp(Node $cond_node, bool $negate): array
{
['left' => $left_node, 'right' => $right_node] = $cond_node->children;
switch ($cond_node->flags) {
case flags\BINARY_IS_SMALLER:- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}