src/Phan/Plugin/Internal/RedundantConditionVisitor.php

Summary

Maintainability
F
4 days
Test Coverage

File RedundantConditionVisitor.php has 524 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Phan\Plugin\Internal;
Severity: Major
Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 1 day to fix

    The class RedundantConditionVisitor has an overall complexity of 106 which is very high. The configured complexity threshold is 50.
    Open

    class RedundantConditionVisitor extends PluginAwarePostAnalysisVisitor
    {
        /**
         * @override
         */

    Method checkUselessScalarComparison has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function checkUselessScalarComparison(
            Node $node,
            UnionType $left,
            UnionType $right,
            $left_node,
    Severity: Major
    Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 3 hrs to fix

      Function visitCast has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function visitCast(Node $node): void
          {
              // TODO: Check if the cast would throw an error at runtime, based on the type (e.g. casting object to string/int)
              $expr_type = UnionTypeVisitor::unionTypeFromNode($this->code_base, $this->context, $node->children['expr']);
              if (!$expr_type->hasRealTypeSet()) {
      Severity: Minor
      Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function checkUselessScalarComparison has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          private function checkUselessScalarComparison(
              Node $node,
              UnionType $left,
              UnionType $right,
              $left_node,
      Severity: Minor
      Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method visitInstanceof has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function visitInstanceof(Node $node): void
          {
              $expr_node = $node->children['expr'];
              $code_base = $this->code_base;
              try {
      Severity: Minor
      Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 2 hrs to fix

        Method visitIsset has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function visitIsset(Node $node): void
            {
                $var_node = $node->children['var'];
                try {
                    $type = UnionTypeVisitor::unionTypeFromNode($this->code_base, $this->context, $var_node, false);
        Severity: Minor
        Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 1 hr to fix

          Method emitIssueForBinaryOp has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function emitIssueForBinaryOp(
                  Node $node,
                  UnionType $left,
                  UnionType $right,
                  string $issue_name,
          Severity: Minor
          Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 1 hr to fix

            Method visitCast has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function visitCast(Node $node): void
                {
                    // TODO: Check if the cast would throw an error at runtime, based on the type (e.g. casting object to string/int)
                    $expr_type = UnionTypeVisitor::unionTypeFromNode($this->code_base, $this->context, $node->children['expr']);
                    if (!$expr_type->hasRealTypeSet()) {
            Severity: Minor
            Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 1 hr to fix

              Method visitEmpty has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function visitEmpty(Node $node): void
                  {
                      $var_node = $node->children['expr'];
                      try {
                          $type = UnionTypeVisitor::unionTypeFromNode($this->code_base, $this->context, $var_node, false);
              Severity: Minor
              Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 1 hr to fix

                Method visitFor has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function visitFor(Node $node): void
                    {
                        $cond_list = $node->children['cond'];
                        if (!$cond_list instanceof Node) {
                            return;
                Severity: Minor
                Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 1 hr to fix

                  Method checkImpossibleComparison has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function checkImpossibleComparison(Node $node, bool $strict): void
                      {
                          $left = UnionTypeVisitor::unionTypeFromNode($this->code_base, $this->context, $node->children['left']);
                          if (!$left->hasRealTypeSet()) {
                              return;
                  Severity: Minor
                  Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 1 hr to fix

                    Function visitFor has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function visitFor(Node $node): void
                        {
                            $cond_list = $node->children['cond'];
                            if (!$cond_list instanceof Node) {
                                return;
                    Severity: Minor
                    Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method emitIssueForBinaryOp has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            Node $node,
                            UnionType $left,
                            UnionType $right,
                            string $issue_name,
                            Closure $is_still_issue,
                    Severity: Major
                    Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 50 mins to fix

                      Method checkUselessScalarComparison has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              Node $node,
                              UnionType $left,
                              UnionType $right,
                              $left_node,
                              $right_node,
                      Severity: Minor
                      Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 45 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return true;
                        Severity: Major
                        Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                                  return;
                          Severity: Major
                          Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return $left;
                            Severity: Major
                            Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                  return $right;
                              Severity: Major
                              Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return false;
                                Severity: Major
                                Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                          return;
                                  Severity: Major
                                  Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                return;
                                    Severity: Major
                                    Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                              return true;
                                      Severity: Major
                                      Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                            return !$type->canPossiblyCastToClass($code_base, $class_type);
                                        Severity: Major
                                        Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                              return $type->isNull();
                                          Severity: Major
                                          Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 30 mins to fix

                                            Function shouldCheckScalarAsIfInLoopScope has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                            Open

                                                private function shouldCheckScalarAsIfInLoopScope(Node $node, $evaluated_value): bool
                                                {
                                                    if (!$this->context->isInLoop()) {
                                                        // This isn't even in a loop.
                                                        return false;
                                            Severity: Minor
                                            Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 25 mins to fix

                                            Cognitive Complexity

                                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                            A method's cognitive complexity is based on a few simple rules:

                                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                            • Code is considered more complex for each "break in the linear flow of the code"
                                            • Code is considered more complex when "flow breaking structures are nested"

                                            Further reading

                                            Function checkImpossibleMatchArm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                            Open

                                                public function checkImpossibleMatchArm(
                                                    $cond_node,
                                                    UnionType $cond_type,
                                                    Node $arm_node
                                                ): void {
                                            Severity: Minor
                                            Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 25 mins to fix

                                            Cognitive Complexity

                                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                            A method's cognitive complexity is based on a few simple rules:

                                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                            • Code is considered more complex for each "break in the linear flow of the code"
                                            • Code is considered more complex when "flow breaking structures are nested"

                                            Further reading

                                            Function checkImpossibleComparison has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                            Open

                                                private function checkImpossibleComparison(Node $node, bool $strict): void
                                                {
                                                    $left = UnionTypeVisitor::unionTypeFromNode($this->code_base, $this->context, $node->children['left']);
                                                    if (!$left->hasRealTypeSet()) {
                                                        return;
                                            Severity: Minor
                                            Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 25 mins to fix

                                            Cognitive Complexity

                                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                            A method's cognitive complexity is based on a few simple rules:

                                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                            • Code is considered more complex for each "break in the linear flow of the code"
                                            • Code is considered more complex when "flow breaking structures are nested"

                                            Further reading

                                            Function visitIsset has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                            Open

                                                public function visitIsset(Node $node): void
                                                {
                                                    $var_node = $node->children['var'];
                                                    try {
                                                        $type = UnionTypeVisitor::unionTypeFromNode($this->code_base, $this->context, $var_node, false);
                                            Severity: Minor
                                            Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 25 mins to fix

                                            Cognitive Complexity

                                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                            A method's cognitive complexity is based on a few simple rules:

                                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                            • Code is considered more complex for each "break in the linear flow of the code"
                                            • Code is considered more complex when "flow breaking structures are nested"

                                            Further reading

                                            Function visitInstanceof has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                            Open

                                                public function visitInstanceof(Node $node): void
                                                {
                                                    $expr_node = $node->children['expr'];
                                                    $code_base = $this->code_base;
                                                    try {
                                            Severity: Minor
                                            Found in src/Phan/Plugin/Internal/RedundantConditionVisitor.php - About 25 mins to fix

                                            Cognitive Complexity

                                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                            A method's cognitive complexity is based on a few simple rules:

                                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                            • Code is considered more complex for each "break in the linear flow of the code"
                                            • Code is considered more complex when "flow breaking structures are nested"

                                            Further reading

                                            The method checkUselessScalarComparison() has 103 lines of code. Current threshold is set to 100. Avoid really long methods.
                                            Open

                                                private function checkUselessScalarComparison(
                                                    Node $node,
                                                    UnionType $left,
                                                    UnionType $right,
                                                    $left_node,

                                            The method checkUselessScalarComparison() has an NPath complexity of 2280. The configured NPath complexity threshold is 200.
                                            Open

                                                private function checkUselessScalarComparison(
                                                    Node $node,
                                                    UnionType $left,
                                                    UnionType $right,
                                                    $left_node,

                                            NPathComplexity

                                            Since: 0.1

                                            The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                            Example

                                            class Foo {
                                                function bar() {
                                                    // lots of complicated code
                                                }
                                            }

                                            Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                            The method checkImpossibleComparison() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                                            Open

                                                private function checkImpossibleComparison(Node $node, bool $strict): void
                                                {
                                                    $left = UnionTypeVisitor::unionTypeFromNode($this->code_base, $this->context, $node->children['left']);
                                                    if (!$left->hasRealTypeSet()) {
                                                        return;

                                            CyclomaticComplexity

                                            Since: 0.1

                                            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                            Example

                                            // Cyclomatic Complexity = 11
                                            class Foo {
                                            1   public function example() {
                                            2       if ($a == $b) {
                                            3           if ($a1 == $b1) {
                                                            fiddle();
                                            4           } elseif ($a2 == $b2) {
                                                            fiddle();
                                                        } else {
                                                            fiddle();
                                                        }
                                            5       } elseif ($c == $d) {
                                            6           while ($c == $d) {
                                                            fiddle();
                                                        }
                                            7        } elseif ($e == $f) {
                                            8           for ($n = 0; $n < $h; $n++) {
                                                            fiddle();
                                                        }
                                                    } else {
                                                        switch ($z) {
                                            9               case 1:
                                                                fiddle();
                                                                break;
                                            10              case 2:
                                                                fiddle();
                                                                break;
                                            11              case 3:
                                                                fiddle();
                                                                break;
                                                            default:
                                                                fiddle();
                                                                break;
                                                        }
                                                    }
                                                }
                                            }

                                            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                            The method checkUselessScalarComparison() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
                                            Open

                                                private function checkUselessScalarComparison(
                                                    Node $node,
                                                    UnionType $left,
                                                    UnionType $right,
                                                    $left_node,

                                            CyclomaticComplexity

                                            Since: 0.1

                                            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                            Example

                                            // Cyclomatic Complexity = 11
                                            class Foo {
                                            1   public function example() {
                                            2       if ($a == $b) {
                                            3           if ($a1 == $b1) {
                                                            fiddle();
                                            4           } elseif ($a2 == $b2) {
                                                            fiddle();
                                                        } else {
                                                            fiddle();
                                                        }
                                            5       } elseif ($c == $d) {
                                            6           while ($c == $d) {
                                                            fiddle();
                                                        }
                                            7        } elseif ($e == $f) {
                                            8           for ($n = 0; $n < $h; $n++) {
                                                            fiddle();
                                                        }
                                                    } else {
                                                        switch ($z) {
                                            9               case 1:
                                                                fiddle();
                                                                break;
                                            10              case 2:
                                                                fiddle();
                                                                break;
                                            11              case 3:
                                                                fiddle();
                                                                break;
                                                            default:
                                                                fiddle();
                                                                break;
                                                        }
                                                    }
                                                }
                                            }

                                            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                            The method visitCast() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
                                            Open

                                                public function visitCast(Node $node): void
                                                {
                                                    // TODO: Check if the cast would throw an error at runtime, based on the type (e.g. casting object to string/int)
                                                    $expr_type = UnionTypeVisitor::unionTypeFromNode($this->code_base, $this->context, $node->children['expr']);
                                                    if (!$expr_type->hasRealTypeSet()) {

                                            CyclomaticComplexity

                                            Since: 0.1

                                            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                            Example

                                            // Cyclomatic Complexity = 11
                                            class Foo {
                                            1   public function example() {
                                            2       if ($a == $b) {
                                            3           if ($a1 == $b1) {
                                                            fiddle();
                                            4           } elseif ($a2 == $b2) {
                                                            fiddle();
                                                        } else {
                                                            fiddle();
                                                        }
                                            5       } elseif ($c == $d) {
                                            6           while ($c == $d) {
                                                            fiddle();
                                                        }
                                            7        } elseif ($e == $f) {
                                            8           for ($n = 0; $n < $h; $n++) {
                                                            fiddle();
                                                        }
                                                    } else {
                                                        switch ($z) {
                                            9               case 1:
                                                                fiddle();
                                                                break;
                                            10              case 2:
                                                                fiddle();
                                                                break;
                                            11              case 3:
                                                                fiddle();
                                                                break;
                                                            default:
                                                                fiddle();
                                                                break;
                                                        }
                                                    }
                                                }
                                            }

                                            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                            The method visitBinaryOp() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                                            Open

                                                public function visitBinaryOp(Node $node): void
                                                {
                                                    switch ($node->flags) {
                                                        case flags\BINARY_IS_IDENTICAL:
                                                        case flags\BINARY_IS_NOT_IDENTICAL:

                                            CyclomaticComplexity

                                            Since: 0.1

                                            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                            Example

                                            // Cyclomatic Complexity = 11
                                            class Foo {
                                            1   public function example() {
                                            2       if ($a == $b) {
                                            3           if ($a1 == $b1) {
                                                            fiddle();
                                            4           } elseif ($a2 == $b2) {
                                                            fiddle();
                                                        } else {
                                                            fiddle();
                                                        }
                                            5       } elseif ($c == $d) {
                                            6           while ($c == $d) {
                                                            fiddle();
                                                        }
                                            7        } elseif ($e == $f) {
                                            8           for ($n = 0; $n < $h; $n++) {
                                                            fiddle();
                                                        }
                                                    } else {
                                                        switch ($z) {
                                            9               case 1:
                                                                fiddle();
                                                                break;
                                            10              case 2:
                                                                fiddle();
                                                                break;
                                            11              case 3:
                                                                fiddle();
                                                                break;
                                                            default:
                                                                fiddle();
                                                                break;
                                                        }
                                                    }
                                                }
                                            }

                                            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                            The class RedundantConditionVisitor has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13.
                                            Open

                                            class RedundantConditionVisitor extends PluginAwarePostAnalysisVisitor
                                            {
                                                /**
                                                 * @override
                                                 */

                                            CouplingBetweenObjects

                                            Since: 1.1.0

                                            A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

                                            Example

                                            class Foo {
                                                /**
                                                 * @var \foo\bar\X
                                                 */
                                                private $x = null;
                                            
                                                /**
                                                 * @var \foo\bar\Y
                                                 */
                                                private $y = null;
                                            
                                                /**
                                                 * @var \foo\bar\Z
                                                 */
                                                private $z = null;
                                            
                                                public function setFoo(\Foo $foo) {}
                                                public function setBar(\Bar $bar) {}
                                                public function setBaz(\Baz $baz) {}
                                            
                                                /**
                                                 * @return \SplObjectStorage
                                                 * @throws \OutOfRangeException
                                                 * @throws \InvalidArgumentException
                                                 * @throws \ErrorException
                                                 */
                                                public function process(\Iterator $it) {}
                                            
                                                // ...
                                            }

                                            Source https://phpmd.org/rules/design.html#couplingbetweenobjects

                                            Avoid variables with short names like $_. Configured minimum length is 3.
                                            Open

                                                            $left_type_fetcher = $left_type_fetcher ?? static function (Context $_) use ($left): UnionType {

                                            ShortVariable

                                            Since: 0.2

                                            Detects when a field, local, or parameter has a very short name.

                                            Example

                                            class Something {
                                                private $q = 15; // VIOLATION - Field
                                                public static function main( array $as ) { // VIOLATION - Formal
                                                    $r = 20 + $this->q; // VIOLATION - Local
                                                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                                        $r += $this->q;
                                                    }
                                                }
                                            }

                                            Source https://phpmd.org/rules/naming.html#shortvariable

                                            There are no issues that match your filters.

                                            Category
                                            Status