Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Plugin/Internal/StringFunctionPlugin.php

Summary

Maintainability
C
1 day
Test Coverage

Method getAnalyzeFunctionCallClosuresStatic has 119 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function getAnalyzeFunctionCallClosuresStatic(): array
    {
        $make_order_warner = static function (int $expected_const_pos, int $expected_variable_pos): Closure {
            $expected_arg_count = 1 + (int)\max($expected_const_pos, $expected_variable_pos);
            /**
Severity: Major
Found in src/Phan/Plugin/Internal/StringFunctionPlugin.php - About 4 hrs to fix

    Function isSimpleExpression has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function isSimpleExpression($arg): bool
    {
        if (\is_scalar($arg)) {
            return true;
        }
    Severity: Minor
    Found in src/Phan/Plugin/Internal/StringFunctionPlugin.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method isSimpleExpression has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function isSimpleExpression($arg): bool
    {
        if (\is_scalar($arg)) {
            return true;
        }
    Severity: Minor
    Found in src/Phan/Plugin/Internal/StringFunctionPlugin.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                      return true;
      Severity: Major
      Found in src/Phan/Plugin/Internal/StringFunctionPlugin.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return false;
        Severity: Major
        Found in src/Phan/Plugin/Internal/StringFunctionPlugin.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return false;
          Severity: Major
          Found in src/Phan/Plugin/Internal/StringFunctionPlugin.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                    return false;
            Severity: Major
            Found in src/Phan/Plugin/Internal/StringFunctionPlugin.php - About 30 mins to fix

              The method getAnalyzeFunctionCallClosuresStatic() has 132 lines of code. Current threshold is set to 100. Avoid really long methods.
              Open

                  private static function getAnalyzeFunctionCallClosuresStatic(): array
    {
        $make_order_warner = static function (int $expected_const_pos, int $expected_variable_pos): Closure {
            $expected_arg_count = 1 + (int)\max($expected_const_pos, $expected_variable_pos);
            /**
              Severity: Minor
              Found in src/Phan/Plugin/Internal/StringFunctionPlugin.php by phpmd

              The method isSimpleExpression() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
              Open

                  private static function isSimpleExpression($arg): bool
    {
        if (\is_scalar($arg)) {
            return true;
        }
              Severity: Minor
              Found in src/Phan/Plugin/Internal/StringFunctionPlugin.php by phpmd

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              Avoid variables with short names like $_. Configured minimum length is 3.
              Open

                              ?Node $_
              Severity: Minor
              Found in src/Phan/Plugin/Internal/StringFunctionPlugin.php by phpmd

              ShortVariable

              Since: 0.2

              Detects when a field, local, or parameter has a very short name.

              Example

              class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

              Source https://phpmd.org/rules/naming.html#shortvariable

              There are no issues that match your filters.

              Category
              Status