Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php

Summary

Maintainability
D
3 days
Test Coverage

File ThrowAnalyzerPlugin.php has 353 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Phan\Plugin\Internal;
Severity: Minor
Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php - About 4 hrs to fix

    Function withoutCaughtUnionTypes has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function withoutCaughtUnionTypes(UnionType $union_type, bool $is_raw_throw): UnionType
    {
        if ($union_type->isEmpty()) {
            if (!$is_raw_throw) {
                return $union_type;
    Severity: Minor
    Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function visitThrow has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        public function visitThrow(Node $node): void
    {
        $code_base = $this->code_base;
        $context = $this->context;
        $union_type = UnionTypeVisitor::unionTypeFromNode($code_base, $context, $node->children['expr']);
    Severity: Minor
    Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function warnAboutPossiblyThrownType has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function warnAboutPossiblyThrownType(
        Node $node,
        FunctionInterface $analyzed_function,
        UnionType $union_type,
        FunctionInterface $call = null
    Severity: Minor
    Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method warnAboutPossiblyThrownType has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function warnAboutPossiblyThrownType(
        Node $node,
        FunctionInterface $analyzed_function,
        UnionType $union_type,
        FunctionInterface $call = null
    Severity: Major
    Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php - About 2 hrs to fix

      Method visitThrow has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function visitThrow(Node $node): void
    {
        $code_base = $this->code_base;
        $context = $this->context;
        $union_type = UnionTypeVisitor::unionTypeFromNode($code_base, $context, $node->children['expr']);
      Severity: Minor
      Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php - About 1 hr to fix

        Method withoutCaughtUnionTypes has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function withoutCaughtUnionTypes(UnionType $union_type, bool $is_raw_throw): UnionType
    {
        if ($union_type->isEmpty()) {
            if (!$is_raw_throw) {
                return $union_type;
        Severity: Minor
        Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php - About 1 hr to fix

          Method visitMethodCall has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function visitMethodCall(Node $node): void
    {
        $context = $this->context;
        if (!$context->isInFunctionLikeScope()) {
            return;
          Severity: Minor
          Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php - About 1 hr to fix

            Method visitStaticCall has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function visitStaticCall(Node $node): void
    {
        $context = $this->context;
        if (!$context->isInFunctionLikeScope()) {
            return;
            Severity: Minor
            Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php - About 1 hr to fix

              Avoid too many return statements within this method.
              Open

                      return $union_type;
              Severity: Major
              Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php - About 30 mins to fix

                The method visitThrow() has an NPath complexity of 608. The configured NPath complexity threshold is 200.
                Open

                    public function visitThrow(Node $node): void
    {
        $code_base = $this->code_base;
        $context = $this->context;
        $union_type = UnionTypeVisitor::unionTypeFromNode($code_base, $context, $node->children['expr']);
                Severity: Minor
                Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
    function bar() {
        // lots of complicated code
    }
}

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method withoutCaughtUnionTypes() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                Open

                    protected function withoutCaughtUnionTypes(UnionType $union_type, bool $is_raw_throw): UnionType
    {
        if ($union_type->isEmpty()) {
            if (!$is_raw_throw) {
                return $union_type;
                Severity: Minor
                Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method visitThrow() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
                Open

                    public function visitThrow(Node $node): void
    {
        $code_base = $this->code_base;
        $context = $this->context;
        $union_type = UnionTypeVisitor::unionTypeFromNode($code_base, $context, $node->children['expr']);
                Severity: Minor
                Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method warnAboutPossiblyThrownType() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                Open

                    protected function warnAboutPossiblyThrownType(
        Node $node,
        FunctionInterface $analyzed_function,
        UnionType $union_type,
        FunctionInterface $call = null
                Severity: Minor
                Found in src/Phan/Plugin/Internal/ThrowAnalyzerPlugin.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                There are no issues that match your filters.

                Category
                Status