src/Phan/Plugin/Internal/UseReturnValuePlugin.php

Summary

Maintainability
D
2 days
Test Coverage

File UseReturnValuePlugin.php has 823 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Phan\Plugin\Internal;
Severity: Major
Found in src/Phan/Plugin/Internal/UseReturnValuePlugin.php - About 1 day to fix

    Function finalizeProcess has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        public function finalizeProcess(CodeBase $code_base): void
        {
            if (!self::$use_dynamic) {
                return;
            }
    Severity: Minor
    Found in src/Phan/Plugin/Internal/UseReturnValuePlugin.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method finalizeProcess has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function finalizeProcess(CodeBase $code_base): void
        {
            if (!self::$use_dynamic) {
                return;
            }
    Severity: Major
    Found in src/Phan/Plugin/Internal/UseReturnValuePlugin.php - About 2 hrs to fix

      The method finalizeProcess() has an NPath complexity of 292. The configured NPath complexity threshold is 200.
      Open

          public function finalizeProcess(CodeBase $code_base): void
          {
              if (!self::$use_dynamic) {
                  return;
              }

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method finalizeProcess() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
      Open

          public function finalizeProcess(CodeBase $code_base): void
          {
              if (!self::$use_dynamic) {
                  return;
              }

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Constant UseReturnValueInternal should be defined in uppercase
      Open

          public const UseReturnValueInternal = 'PhanPluginUseReturnValueInternal';

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant UseReturnValueInternalKnown should be defined in uppercase
      Open

          public const UseReturnValueInternalKnown = 'PhanPluginUseReturnValueInternalKnown';

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant UseReturnValueKnown should be defined in uppercase
      Open

          public const UseReturnValueKnown = 'PhanPluginUseReturnValueKnown';

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant UseReturnValueNoopVoid should be defined in uppercase
      Open

          public const UseReturnValueNoopVoid = 'PhanPluginUseReturnValueNoopVoid';

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant UseReturnValueGenerator should be defined in uppercase
      Open

          public const UseReturnValueGenerator = 'PhanPluginUseReturnValueGenerator';

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant UseReturnValue should be defined in uppercase
      Open

          public const UseReturnValue = 'PhanPluginUseReturnValue';

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      There are no issues that match your filters.

      Category
      Status