Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Plugin/Internal/UseReturnValuePlugin/PureMethodGraph.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function recursivelyMarkNodesAsPure has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function recursivelyMarkNodesAsPure(): void
    {
        // Go through the graph. Any nodes that are impure would either never be added to $this->functions,
        // or be removed in handleImpureFunction.
        $reverse_edges = [];
Severity: Minor
Found in src/Phan/Plugin/Internal/UseReturnValuePlugin/PureMethodGraph.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method recursivelyMarkNodesAsPure has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function recursivelyMarkNodesAsPure(): void
    {
        // Go through the graph. Any nodes that are impure would either never be added to $this->functions,
        // or be removed in handleImpureFunction.
        $reverse_edges = [];
Severity: Minor
Found in src/Phan/Plugin/Internal/UseReturnValuePlugin/PureMethodGraph.php - About 1 hr to fix

    Function isVoidFunction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function isVoidFunction(FunctionInterface $function): bool
    {
        if ($function->getUnionType()->isNull()) {
            return true;
        }
    Severity: Minor
    Found in src/Phan/Plugin/Internal/UseReturnValuePlugin/PureMethodGraph.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status