src/Phan/Plugin/Internal/VariableTrackerPlugin.php

Summary

Maintainability
F
6 days
Test Coverage

Function warnAboutVariableGraph has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

    private function warnAboutVariableGraph(
        Node $method_node,
        VariableGraph $graph,
        array $issue_overrides_for_definition_ids
    ): void {
Severity: Minor
Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkPossiblyInfiniteLoopNodes has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

    private function checkPossiblyInfiniteLoopNodes(
        VariableGraph $variable_graph,
        VariableTrackerVisitor $variable_tracker_visitor
    ): void {
        $loop_nodes = $variable_tracker_visitor->getPossiblyInfiniteLoopNodes();
Severity: Minor
Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File VariableTrackerPlugin.php has 489 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Phan\Plugin\Internal;
Severity: Minor
Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 7 hrs to fix

    Function addParametersAndUseVariablesToGraph has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function addParametersAndUseVariablesToGraph(
            Node $node,
            VariableGraph $graph,
            VariableTrackingScope $scope
        ): array {
    Severity: Minor
    Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The class VariableTrackerElementVisitor has an overall complexity of 124 which is very high. The configured complexity threshold is 50.
    Open

    final class VariableTrackerElementVisitor extends PluginAwarePostAnalysisVisitor
    {
        public function visitMethod(Node $node): void
        {
            $this->analyzeMethodLike($node);

    Method warnAboutVariableGraph has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function warnAboutVariableGraph(
            Node $method_node,
            VariableGraph $graph,
            array $issue_overrides_for_definition_ids
        ): void {
    Severity: Major
    Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 2 hrs to fix

      Method checkPossiblyInfiniteLoopNodes has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function checkPossiblyInfiniteLoopNodes(
              VariableGraph $variable_graph,
              VariableTrackerVisitor $variable_tracker_visitor
          ): void {
              $loop_nodes = $variable_tracker_visitor->getPossiblyInfiniteLoopNodes();
      Severity: Minor
      Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 hr to fix

        Function warnAboutCouldBeConstant has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            private function warnAboutCouldBeConstant(VariableGraph $graph, string $variable_name, int $definition_id, $value_node): void
            {
                $issue_type = Issue::VariableDefinitionCouldBeConstant;
                if ($value_node instanceof Node) {
                    if ($value_node->kind === ast\AST_ARRAY) {
        Severity: Minor
        Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method addParametersAndUseVariablesToGraph has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static function addParametersAndUseVariablesToGraph(
                Node $node,
                VariableGraph $graph,
                VariableTrackingScope $scope
            ): array {
        Severity: Minor
        Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 hr to fix

          Method checkSingleDefinitionReferenceOrGlobalOrStatic has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function checkSingleDefinitionReferenceOrGlobalOrStatic(
                  VariableGraph $graph,
                  string $variable_name,
                  array $issue_overrides_for_definition_ids
              ): void {
          Severity: Minor
          Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 hr to fix

            Method warnAboutCouldBeConstant has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function warnAboutCouldBeConstant(VariableGraph $graph, string $variable_name, int $definition_id, $value_node): void
                {
                    $issue_type = Issue::VariableDefinitionCouldBeConstant;
                    if ($value_node instanceof Node) {
                        if ($value_node->kind === ast\AST_ARRAY) {
            Severity: Minor
            Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 hr to fix

              Function definitionInsideNodeHasUseOutsideNode has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  private static function definitionInsideNodeHasUseOutsideNode(array $combined_def_uses, Node $loop_node): bool
                  {
                      if (!$combined_def_uses) {
                          return false;
                      }
              Severity: Minor
              Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getParameterCategory has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function getParameterCategory(Node $method_node): string
                  {
                      $kind = $method_node->kind;
                      if ($kind === ast\AST_CLOSURE) {
                          return Issue::UnusedClosureParameter;
              Severity: Minor
              Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getParameterCategory has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function getParameterCategory(Node $method_node): string
                  {
                      $kind = $method_node->kind;
                      if ($kind === ast\AST_CLOSURE) {
                          return Issue::UnusedClosureParameter;
              Severity: Minor
              Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 hr to fix

                Function checkSingleDefinitionReferenceOrGlobalOrStatic has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function checkSingleDefinitionReferenceOrGlobalOrStatic(
                        VariableGraph $graph,
                        string $variable_name,
                        array $issue_overrides_for_definition_ids
                    ): void {
                Severity: Minor
                Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                            return Issue::UnusedProtectedMethodParameter;
                Severity: Major
                Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return null;
                  Severity: Major
                  Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return Issue::UnusedPublicMethodParameter;
                    Severity: Major
                    Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return Issue::UnusedPublicFinalMethodParameter;
                      Severity: Major
                      Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return Issue::UnusedPublicNoOverrideMethodParameter;
                        Severity: Major
                        Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return Issue::UnusedProtectedNoOverrideMethodParameter;
                          Severity: Major
                          Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return Suggestion::fromString('Did you mean ' . \implode(' or ', $suggestions));
                            Severity: Major
                            Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 30 mins to fix

                              Function makeSuggestion has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  private static function makeSuggestion(VariableGraph $graph, string $variable_name, string $issue_type): ?Suggestion
                                  {
                                      if ($issue_type !== Issue::UnusedVariable) {
                                          return null;
                                      }
                              Severity: Minor
                              Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              The method warnAboutVariableGraph() has an NPath complexity of 21473. The configured NPath complexity threshold is 200.
                              Open

                                  private function warnAboutVariableGraph(
                                      Node $method_node,
                                      VariableGraph $graph,
                                      array $issue_overrides_for_definition_ids
                                  ): void {

                              NPathComplexity

                              Since: 0.1

                              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                              Example

                              class Foo {
                                  function bar() {
                                      // lots of complicated code
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#npathcomplexity

                              The method checkPossiblyInfiniteLoopNodes() has an NPath complexity of 890. The configured NPath complexity threshold is 200.
                              Open

                                  private function checkPossiblyInfiniteLoopNodes(
                                      VariableGraph $variable_graph,
                                      VariableTrackerVisitor $variable_tracker_visitor
                                  ): void {
                                      $loop_nodes = $variable_tracker_visitor->getPossiblyInfiniteLoopNodes();

                              NPathComplexity

                              Since: 0.1

                              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                              Example

                              class Foo {
                                  function bar() {
                                      // lots of complicated code
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#npathcomplexity

                              The method addParametersAndUseVariablesToGraph() has an NPath complexity of 612. The configured NPath complexity threshold is 200.
                              Open

                                  private static function addParametersAndUseVariablesToGraph(
                                      Node $node,
                                      VariableGraph $graph,
                                      VariableTrackingScope $scope
                                  ): array {

                              NPathComplexity

                              Since: 0.1

                              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                              Example

                              class Foo {
                                  function bar() {
                                      // lots of complicated code
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#npathcomplexity

                              The method checkPossiblyInfiniteLoopNodes() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
                              Open

                                  private function checkPossiblyInfiniteLoopNodes(
                                      VariableGraph $variable_graph,
                                      VariableTrackerVisitor $variable_tracker_visitor
                                  ): void {
                                      $loop_nodes = $variable_tracker_visitor->getPossiblyInfiniteLoopNodes();

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The method getParameterCategory() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                              Open

                                  private function getParameterCategory(Node $method_node): string
                                  {
                                      $kind = $method_node->kind;
                                      if ($kind === ast\AST_CLOSURE) {
                                          return Issue::UnusedClosureParameter;

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The method warnAboutVariableGraph() has a Cyclomatic Complexity of 25. The configured cyclomatic complexity threshold is 10.
                              Open

                                  private function warnAboutVariableGraph(
                                      Node $method_node,
                                      VariableGraph $graph,
                                      array $issue_overrides_for_definition_ids
                                  ): void {

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The method addParametersAndUseVariablesToGraph() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                              Open

                                  private static function addParametersAndUseVariablesToGraph(
                                      Node $node,
                                      VariableGraph $graph,
                                      VariableTrackingScope $scope
                                  ): array {

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The method warnAboutCouldBeConstant() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                              Open

                                  private function warnAboutCouldBeConstant(VariableGraph $graph, string $variable_name, int $definition_id, $value_node): void
                                  {
                                      $issue_type = Issue::VariableDefinitionCouldBeConstant;
                                      if ($value_node instanceof Node) {
                                          if ($value_node->kind === ast\AST_ARRAY) {

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The class VariableTrackerElementVisitor has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
                              Open

                              final class VariableTrackerElementVisitor extends PluginAwarePostAnalysisVisitor
                              {
                                  public function visitMethod(Node $node): void
                                  {
                                      $this->analyzeMethodLike($node);

                              CouplingBetweenObjects

                              Since: 1.1.0

                              A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

                              Example

                              class Foo {
                                  /**
                                   * @var \foo\bar\X
                                   */
                                  private $x = null;
                              
                                  /**
                                   * @var \foo\bar\Y
                                   */
                                  private $y = null;
                              
                                  /**
                                   * @var \foo\bar\Z
                                   */
                                  private $z = null;
                              
                                  public function setFoo(\Foo $foo) {}
                                  public function setBar(\Bar $bar) {}
                                  public function setBaz(\Baz $baz) {}
                              
                                  /**
                                   * @return \SplObjectStorage
                                   * @throws \OutOfRangeException
                                   * @throws \InvalidArgumentException
                                   * @throws \ErrorException
                                   */
                                  public function process(\Iterator $it) {}
                              
                                  // ...
                              }

                              Source https://phpmd.org/rules/design.html#couplingbetweenobjects

                              Avoid using empty try-catch blocks in isParameterFinal.
                              Open

                                          } catch (CodeBaseException $_) {
                                          }

                              EmptyCatchBlock

                              Since: 2.7.0

                              Usually empty try-catch is a bad idea because you are silently swallowing an error condition and then continuing execution. Occasionally this may be the right thing to do, but often it's a sign that a developer saw an exception, didn't know what to do about it, and so used an empty catch to silence the problem.

                              Example

                              class Foo {
                              
                                public function bar()
                                {
                                    try {
                                        // ...
                                    } catch (Exception $e) {} // empty catch block
                                }
                              }

                              Source https://phpmd.org/rules/design.html#emptycatchblock

                              Avoid variables with short names like $id. Configured minimum length is 3.
                              Open

                                      $id = \spl_object_id($node);

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              There are no issues that match your filters.

                              Category
                              Status