Sign upLogin

etz69/irhelper

View on GitHub
Star
modules/cmds/vol_pslist_module.py

Summary

Maintainability
F
5 days
Test Coverage

Function vol_pslist has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

def vol_pslist(_project):
    global result

    print_header("Executing vol_pslist...")
    rdb = dbops.DBOps(_project.db_name)
Severity: Minor
Found in modules/cmds/vol_pslist_module.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function analyse_processes has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

def analyse_processes(_project):
    '''
    This module will check all running processes to verify that the correct
    parent process has spawned the running one.
    Some ideas like the rules format has been taken from DAMM - @ 504ENSICS Labs
Severity: Minor
Found in modules/cmds/vol_pslist_module.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File vol_pslist_module.py has 415 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import collections
import json
import sys

sys.path.append(sys.path[0]+"/../../")
Severity: Minor
Found in modules/cmds/vol_pslist_module.py - About 5 hrs to fix

Function analyse_scan_processes has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

def analyse_scan_processes(_project):

    ## First we retrieve psxview all processes
    global result
    print_header("Gathering information from scan process")
Severity: Minor
Found in modules/cmds/vol_pslist_module.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function enrich_pslist has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def enrich_pslist(_project, plist):

    rdbl = dbops.DBOps(_project.db_name)
    query = "select FileName,CompanyName,OriginalFileName," \
            "FileDescription,FileSize,LegalCopyright,FileDescription,md5," \
Severity: Minor
Found in modules/cmds/vol_pslist_module.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if n not in jdata_keys:
                            jdata_keys.append(n)
Severity: Major
Found in modules/cmds/vol_pslist_module.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                    if check in process:
                        ###NOt all have peb information
                        if not str(process[check]).lower() == str(rule_list[key][check]).lower() and str(process[check]).lower() != "nopeb" :

                            print("Violation detected on: [%s] "
Severity: Major
Found in modules/cmds/vol_pslist_module.py - About 45 mins to fix

Function calculate_md5 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def calculate_md5():
    print_header("Calculating MD5 of dumped files..")

    rdb = dbops.DBOps("results.db")
Severity: Minor
Found in modules/cmds/vol_pslist_module.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    for plugin in volatility_plugins:

        if not rdb.table_exists(plugin['table']):
            rc, result = execute_volatility_plugin(plugin_type=plugin['type'],
                                                   plugin_name=plugin['name'],
Severity: Major
Found in modules/cmds/vol_pslist_module.py and 2 other locations - About 1 day to fix
modules/cmds/vol_getosversion_module.py on lines 64..79
modules/cmds/vol_regdump_module.py on lines 36..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 140.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Wontfix

if __name__ == "__main__":
    #
    print("Python version: %s\n " % sys.version)
    DB_NAME = "results.db"
Severity: Major
Found in modules/cmds/vol_pslist_module.py and 6 other locations - About 1 day to fix
modules/cmds/skeleton_module.py on lines 47..68
modules/cmds/vol_cmdline_module.py on lines 65..86
modules/cmds/vol_getosversion_module.py on lines 130..149
modules/cmds/vol_malfind_extended_module.py on lines 144..164
modules/cmds/vol_netscan_module.py on lines 273..292
modules/cmds/vol_regdump_module.py on lines 139..158

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 8 locations. Consider refactoring.
Open

def show_json(in_response):
    ##Function to test json output
    try:
        print(json.dumps(in_response, sort_keys=False, indent=4))
    except TypeError as e:
Severity: Major
Found in modules/cmds/vol_pslist_module.py and 7 other locations - About 2 hrs to fix
modules/cmds/skeleton_module.py on lines 38..43
modules/cmds/vol_cmdline_module.py on lines 56..61
modules/cmds/vol_getosversion_module.py on lines 121..126
modules/cmds/vol_imageinfo_module.py on lines 61..66
modules/cmds/vol_malfind_extended_module.py on lines 135..140
modules/cmds/vol_netscan_module.py on lines 265..270
modules/cmds/vol_regdump_module.py on lines 131..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status