Sign upLogin

eure/bobo-googlehome

View on GitHub
Star

Showing 9 of 9 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package googlehome

import (
    "errors"
Severity: Major
Found in googlehome/example_task_cast_play.go and 1 other location - About 2 hrs to fix
googlehome/example_task_cast_volume.go on lines 1..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 227.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package googlehome

import (
    "errors"
Severity: Major
Found in googlehome/example_task_cast_volume.go and 1 other location - About 2 hrs to fix
googlehome/example_task_cast_play.go on lines 1..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 227.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

exported func NewReloadClientTask returns unexported type googlehome.reloadClientTask, which can be annoying to use
Open

func NewReloadClientTask() (reloadClientTask, error) {
Severity: Minor
Found in googlehome/example_task_reload_client.go by golint

exported func NewCastPlayTaskWithClient returns unexported type googlehome.castPlayTask, which can be annoying to use
Open

func NewCastPlayTaskWithClient(client *googlehome.Client, text string) castPlayTask {
Severity: Minor
Found in googlehome/example_task_cast_play.go by golint

exported func NewCastVolumeTaskWithClient returns unexported type googlehome.castVolumeTask, which can be annoying to use
Open

func NewCastVolumeTaskWithClient(client *googlehome.Client, volume float64) castVolumeTask {
Severity: Minor
Found in googlehome/example_task_cast_volume.go by golint

2: cannot find package "github.com/eure/bobo" in any of:
Open

    "github.com/eure/bobo"
Severity: Minor
Found in cmd/main.go by govet

exported func NewCastPlayTask returns unexported type googlehome.castPlayTask, which can be annoying to use
Open

func NewCastPlayTask(text string) (castPlayTask, error) {
Severity: Minor
Found in googlehome/example_task_cast_play.go by golint

exported func NewCastVolumeTask returns unexported type googlehome.castVolumeTask, which can be annoying to use
Open

func NewCastVolumeTask(volume float64) (castVolumeTask, error) {
Severity: Minor
Found in googlehome/example_task_cast_volume.go by golint

exported func NewReloadClientTaskWithClient returns unexported type googlehome.reloadClientTask, which can be annoying to use
Open

func NewReloadClientTaskWithClient(client *googlehome.Client) reloadClientTask {
Severity: Minor
Found in googlehome/example_task_reload_client.go by golint
Severity
Category
Status
Source
Language