europeana/europeana-api-client-ruby

View on GitHub
lib/europeana/api/faraday_middleware/response/parse_json_to_various.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use each_key instead of keys.each.
Open

            hash.keys.each do |k|

This cop checks for uses of each_key and each_value Hash methods.

Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

Example:

# bad
hash.keys.each { |k| p k }
hash.values.each { |v| p v }
hash.each { |k, _v| p k }
hash.each { |_k, v| p v }

# good
hash.each_key { |k| p k }
hash.each_value { |v| p v }

Add an empty line after magic comments.
Open

require 'faraday_middleware/response_middleware'

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

There are no issues that match your filters.

Category
Status