Sign upLogin

eustasy/phoenix

View on GitHub
Star

Showing 67 of 68 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

if ( is_readable($settings['settings'].'phoenix.custom.php') ) {
    include $settings['settings'].'phoenix.custom.php';
} else {
    error_log('Configuration file "'.$settings['settings'].'phoenix.custom.php" not readable.'.PHP_EOL.
        'Falling back to defaults.');
Severity: Major
Found in _phoenix.php and 1 other location - About 1 hr to fix
_onces/phoenix/once.test.initialize.php on lines 6..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

if ( is_readable(__DIR__.'/../../_settings/phoenix.custom.php') ) {
    require_once __DIR__.'/../../_settings/phoenix.custom.php';
} else {
    error_log('Configuration file "'.$settings['settings'].'phoenix.custom.php" not readable.'.PHP_EOL.
        'Falling back to defaults.');
Severity: Major
Found in _onces/phoenix/once.test.initialize.php and 1 other location - About 1 hr to fix
_phoenix.php on lines 31..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Consider simplifying this complex logical expression.
Open

if (
    // No Existing Peer
    !$peer['old'] ||
    // IP has changed.
    $peer['ipv4'] != $peer['old']['ipv4'] ||
Severity: Major
Found in _onces/phoenix/once.announce.peer.event.php - About 40 mins to fix

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in _onces/phoenix/once.scrape.output.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in announce.php by phpcodesniffer

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

    }
    Severity: Minor
    Found in _functions/phoenix/function.task.optimize.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in _onces/phoenix/once.announce.torrent.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in _onces/phoenix/once.db.connect.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in admin.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in _onces/phoenix/once.announce.peer.event.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in _onces/phoenix/once.announce.torrent.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in _onces/phoenix/once.stats.tracker.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in _onces/phoenix/once.stats.tracker.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in scrape.php by phpcodesniffer

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

    }
    Severity: Minor
    Found in _functions/phoenix/function.peer.new.php by phpcodesniffer

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

    }
    Severity: Minor
    Found in _functions/phoenix/function.task.clean.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in _onces/phoenix/once.sanitize.announce.address.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in announce.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in admin.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in admin.php by phpcodesniffer
    Severity
    Category
    Status
    Source
    Language