Sign upLogin

eustatos/pure-md5

View on GitHub
Star

Showing 8 of 8 total issues

Function md5cycle has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function md5cycle(x: number[], k: number[], fn?): void {
  if (typeof fn === 'undefined') {
    fn = add32;
  }
  let a = x[0];
Severity: Major
Found in src/md5cycle.ts - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const fn = function add32(x, y) {
      let lsw = (x & 0xffff) + (y & 0xffff);
      let msw = (x >> 16) + (y >> 16) + (lsw >> 16);
      return (msw << 16) | (lsw & 0xffff);
    };
    Severity: Major
    Found in src/add32.test.ts and 1 other location - About 1 hr to fix
    src/index.ts on lines 8..12

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        fn = function add32(x, y) {
      let lsw = (x & 0xffff) + (y & 0xffff);
      let msw = (x >> 16) + (y >> 16) + (lsw >> 16);
      return (msw << 16) | (lsw & 0xffff);
    };
    Severity: Major
    Found in src/index.ts and 1 other location - About 1 hr to fix
    src/add32.test.ts on lines 5..9

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function gg has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      fn,
  a: number,
  b: number,
  c: number,
  d: number,
    Severity: Major
    Found in src/gg.ts - About 1 hr to fix

      Function hh has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        fn,
  a: number,
  b: number,
  c: number,
  d: number,
      Severity: Major
      Found in src/hh.ts - About 1 hr to fix

        Function ii has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          fn,
  a: number,
  b: number,
  c: number,
  d: number,
        Severity: Major
        Found in src/ii.ts - About 1 hr to fix

          Function ff has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            fn,
  a: number,
  b: number,
  c: number,
  d: number,
          Severity: Major
          Found in src/ff.ts - About 1 hr to fix

            Function cmn has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              q: number,
  a: number,
  b: number,
  x: number,
  s: number,
            Severity: Major
            Found in src/cmn.ts - About 50 mins to fix
              Severity
              Category
              Status
              Source
              Language