Sign upLogin

evalphobia/aws-sdk-go-v2-wrapper

View on GitHub
Star
dynamodb/client_op_item_query.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method QueryRequest.ToInput has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
Open

func (r QueryRequest) ToInput() (*SDK.QueryInput, error) {
    in := &SDK.QueryInput{}

    if r.TableName != "" {
        in.TableName = pointers.String(r.TableName)
Severity: Minor
Found in dynamodb/client_op_item_query.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method QueryRequest.ToInput has 71 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r QueryRequest) ToInput() (*SDK.QueryInput, error) {
    in := &SDK.QueryInput{}

    if r.TableName != "" {
        in.TableName = pointers.String(r.TableName)
Severity: Minor
Found in dynamodb/client_op_item_query.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func NewQueryResult(output *SDK.QueryResponse) *QueryResult {
    r := &QueryResult{}
    if output == nil {
        return r
    }
    Severity: Major
    Found in dynamodb/client_op_item_query.go and 1 other location - About 1 hr to fix
    dynamodb/client_op_item_scan.go on lines 122..143

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 176.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (svc *DynamoDB) Query(ctx context.Context, r QueryRequest) (*QueryResult, error) {
    in, err := r.ToInput()
    if err != nil {
        return nil, err
    }
    Severity: Major
    Found in dynamodb/client_op_item_query.go and 2 other locations - About 1 hr to fix
    dynamodb/client_op_item_scan.go on lines 13..30
    dynamodb/client_op_item_update.go on lines 13..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 160.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    exported function NewQueryResult should have comment or be unexported
    Open

    func NewQueryResult(output *SDK.QueryResponse) *QueryResult {
    Severity: Minor
    Found in dynamodb/client_op_item_query.go by golint

    exported method QueryResult.ToSliceMap should have comment or be unexported
    Open

    func (r QueryResult) ToSliceMap() ([]map[string]interface{}, error) {
    Severity: Minor
    Found in dynamodb/client_op_item_query.go by golint

    exported method QueryRequest.ToInput should have comment or be unexported
    Open

    func (r QueryRequest) ToInput() (*SDK.QueryInput, error) {
    Severity: Minor
    Found in dynamodb/client_op_item_query.go by golint

    exported method QueryResult.Unmarshal should have comment or be unexported
    Open

    func (r QueryResult) Unmarshal(out interface{}) error {
    Severity: Minor
    Found in dynamodb/client_op_item_query.go by golint

    There are no issues that match your filters.

    Category
    Status