Similar blocks of code found in 2 locations. Consider refactoring. Open
func newEndpointLocation(o *SDK.EndpointLocation) EndpointLocation {
result := EndpointLocation{}
if o.City != nil {
result.City = *o.City
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 187.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
exported type EndpointBatchItem should have comment or be unexported Open
type EndpointBatchItem struct {
- Exclude checks
exported method EndpointDemographic.ToSDK should have comment or be unexported Open
func (r EndpointDemographic) ToSDK() *SDK.EndpointDemographic {
- Exclude checks
exported method EndpointRequest.ToSDK should have comment or be unexported Open
func (r EndpointRequest) ToSDK() *SDK.EndpointRequest {
- Exclude checks
exported method EndpointBatchRequest.ToSDK should have comment or be unexported Open
func (r EndpointBatchRequest) ToSDK() *SDK.EndpointBatchRequest {
- Exclude checks
exported type EndpointResponse should have comment or be unexported Open
type EndpointResponse struct {
- Exclude checks
exported type EndpointsResponse should have comment or be unexported Open
type EndpointsResponse struct {
- Exclude checks
exported type EndpointLocation should have comment or be unexported Open
type EndpointLocation struct {
- Exclude checks
exported type EndpointDemographic should have comment or be unexported Open
type EndpointDemographic struct {
- Exclude checks
exported method EndpointBatchItem.ToSDK should have comment or be unexported Open
func (r EndpointBatchItem) ToSDK() SDK.EndpointBatchItem {
- Exclude checks
exported method EndpointUser.ToSDK should have comment or be unexported Open
func (r EndpointUser) ToSDK() *SDK.EndpointUser {
- Exclude checks
exported type EndpointUser should have comment or be unexported Open
type EndpointUser struct {
- Exclude checks
exported type EndpointBatchRequest should have comment or be unexported Open
type EndpointBatchRequest struct {
- Exclude checks
exported type EndpointRequest should have comment or be unexported Open
type EndpointRequest struct {
- Exclude checks
exported method EndpointLocation.ToSDK should have comment or be unexported Open
func (r EndpointLocation) ToSDK() *SDK.EndpointLocation {
- Exclude checks