Sign upLogin

evalphobia/aws-sdk-go-v2-wrapper

View on GitHub
Star
pinpoint/type_template.go

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func newTemplatesResponse(o *SDK.TemplatesResponse) TemplatesResponse {
    result := TemplatesResponse{}
    if o == nil {
        return result
    }
Severity: Major
Found in pinpoint/type_template.go and 3 other locations - About 1 hr to fix
pinpoint/type_application.go on lines 12..31
pinpoint/type_job.go on lines 52..72
pinpoint/type_segment.go on lines 399..419

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func newCreateTemplateMessageBody(o *SDK.CreateTemplateMessageBody) CreateTemplateMessageBody {
    result := CreateTemplateMessageBody{}
    if o == nil {
        return result
    }
Severity: Major
Found in pinpoint/type_template.go and 4 other locations - About 1 hr to fix
dynamodb/type.go on lines 18..34
dynamodb/type.go on lines 361..377
s3/type.go on lines 450..466
ssm/type.go on lines 131..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 138.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

func newMessageBody(o *SDK.MessageBody) MessageBody {
    result := MessageBody{}
    if o == nil {
        return result
    }
Severity: Major
Found in pinpoint/type_template.go and 6 other locations - About 40 mins to fix
athena/type.go on lines 111..124
pinpoint/type_campaign.go on lines 644..657
pinpoint/type_campaign.go on lines 764..777
pinpoint/type_segment.go on lines 311..324
s3/type.go on lines 644..657
ses/type.go on lines 152..165

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

exported method DefaultPushNotificationTemplate.ToSDK should have comment or be unexported
Open

func (r DefaultPushNotificationTemplate) ToSDK() *SDK.DefaultPushNotificationTemplate {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported method PushNotificationTemplateRequest.ToSDK should have comment or be unexported
Open

func (r PushNotificationTemplateRequest) ToSDK() *SDK.PushNotificationTemplateRequest {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported method AndroidPushNotificationTemplate.ToSDK should have comment or be unexported
Open

func (r AndroidPushNotificationTemplate) ToSDK() *SDK.AndroidPushNotificationTemplate {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported type EmailTemplateRequest should have comment or be unexported
Open

type EmailTemplateRequest struct {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported type DefaultPushNotificationTemplate should have comment or be unexported
Open

type DefaultPushNotificationTemplate struct {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported type PushNotificationTemplateRequest should have comment or be unexported
Open

type PushNotificationTemplateRequest struct {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported type TemplateResponse should have comment or be unexported
Open

type TemplateResponse struct {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported type APNsPushNotificationTemplate should have comment or be unexported
Open

type APNsPushNotificationTemplate struct {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported method APNsPushNotificationTemplate.ToSDK should have comment or be unexported
Open

func (r APNsPushNotificationTemplate) ToSDK() *SDK.APNSPushNotificationTemplate {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported type CreateTemplateMessageBody should have comment or be unexported
Open

type CreateTemplateMessageBody struct {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported method EmailTemplateRequest.ToSDK should have comment or be unexported
Open

func (r EmailTemplateRequest) ToSDK() *SDK.EmailTemplateRequest {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported type TemplatesResponse should have comment or be unexported
Open

type TemplatesResponse struct {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported type AndroidPushNotificationTemplate should have comment or be unexported
Open

type AndroidPushNotificationTemplate struct {
Severity: Minor
Found in pinpoint/type_template.go by golint

exported type MessageBody should have comment or be unexported
Open

type MessageBody struct {
Severity: Minor
Found in pinpoint/type_template.go by golint

There are no issues that match your filters.

Category
Status