evalphobia/eurekache

View on GitHub

Showing 9 of 9 total issues

Function TestItems has 65 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestItems(t *testing.T) {
    assert := assert.New(t)

    tests := []struct {
        max   int
Severity: Minor
Found in memorycache/memory_test.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (e *Eurekache) GetInterface(key string) (v interface{}, ok bool) {
        ch := make(chan bool, 1)
        // get cache
        go func() {
            for _, c := range e.caches {
    Severity: Minor
    Found in eurekache.go and 1 other location - About 40 mins to fix
    eurekache.go on lines 114..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (e *Eurekache) GetGobBytes(key string) (b []byte, ok bool) {
        ch := make(chan bool, 1)
        // get cache
        go func() {
            for _, c := range e.caches {
    Severity: Minor
    Found in eurekache.go and 1 other location - About 40 mins to fix
    eurekache.go on lines 90..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method RedisCache.getGobItem has 5 return statements (exceeds 4 allowed).
    Open

    func (c *RedisCache) getGobItem(key string) (*eurekache.Item, bool) {
        conn, err := c.conn()
        if err != nil {
            return nil, false
        }
    Severity: Major
    Found in rediscache/redis.go - About 35 mins to fix

      Method RedisCache.SetExpire has 5 return statements (exceeds 4 allowed).
      Open

      func (c *RedisCache) SetExpire(key string, data interface{}, ttl int64) error {
          conn, err := c.conn()
          if err != nil {
              return err
          }
      Severity: Major
      Found in rediscache/redis.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func TestGetInterface(t *testing.T) {
            assert := assert.New(t)
        
            e := New()
            m := newDummyCache()
        Severity: Minor
        Found in eurekache_test.go and 1 other location - About 30 mins to fix
        eurekache_test.go on lines 75..85

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func TestGetGobBytes(t *testing.T) {
            assert := assert.New(t)
        
            e := New()
            m := newDummyCache()
        Severity: Minor
        Found in eurekache_test.go and 1 other location - About 30 mins to fix
        eurekache_test.go on lines 63..73

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        exported function TestGobItem should have comment or be unexported
        Open

        func TestGobItem(v interface{}) []byte {
        Severity: Minor
        Found in test/helper/helper.go by golint

        exported function TestGetPool should have comment or be unexported
        Open

        func TestGetPool() *redis.Pool {
        Severity: Minor
        Found in test/helper/helper.go by golint
        Severity
        Category
        Status
        Source
        Language