Sign upLogin

evalphobia/hierogolyph

View on GitHub
Star
hierogolyph_benchmark_test.go

Summary

Maintainability
C
1 day
Test Coverage

Function runDecrypt has 61 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func runDecrypt(b *testing.B, conf Config) {
    h, err := CreateHierogolyph(testHierogolyph1.Password, conf)
    if err != nil {
        b.Error(err)
        return
Severity: Minor
Found in hierogolyph_benchmark_test.go - About 1 hr to fix

    Function runDecrypt has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
    Open

    func runDecrypt(b *testing.B, conf Config) {
    h, err := CreateHierogolyph(testHierogolyph1.Password, conf)
    if err != nil {
        b.Error(err)
        return
    Severity: Minor
    Found in hierogolyph_benchmark_test.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function runDecrypt has 9 return statements (exceeds 4 allowed).
    Open

    func runDecrypt(b *testing.B, conf Config) {
    h, err := CreateHierogolyph(testHierogolyph1.Password, conf)
    if err != nil {
        b.Error(err)
        return
    Severity: Major
    Found in hierogolyph_benchmark_test.go - About 55 mins to fix

      Function runEncrypt has 5 return statements (exceeds 4 allowed).
      Open

      func runEncrypt(b *testing.B, conf Config) {
    h, err := CreateHierogolyph(testHierogolyph1.Password, conf)
    if err != nil {
        b.Error(err)
        return
      Severity: Major
      Found in hierogolyph_benchmark_test.go - About 35 mins to fix

        Function runEncrypt has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func runEncrypt(b *testing.B, conf Config) {
    h, err := CreateHierogolyph(testHierogolyph1.Password, conf)
    if err != nil {
        b.Error(err)
        return
        Severity: Minor
        Found in hierogolyph_benchmark_test.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func Benchmark_Decrypt(b *testing.B) {
    b.Run("Cipher=AESGCM::HSM=AESGCM::Hasher::Argon2id", func(b *testing.B) {
        conf := Config{
            Cipher:  aesgcm.Cipher{},
            HSM:     hsmgcm.NewMockHSM([]byte(testGCMKey256)),
        Severity: Major
        Found in hierogolyph_benchmark_test.go and 1 other location - About 3 hrs to fix
        hierogolyph_benchmark_test.go on lines 22..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 301.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func Benchmark_Encrypt(b *testing.B) {
    b.Run("Cipher=AESGCM::HSM=AESGCM::Hasher::Argon2id", func(b *testing.B) {
        conf := Config{
            Cipher:  aesgcm.Cipher{},
            HSM:     hsmgcm.NewMockHSM([]byte(testGCMKey256)),
        Severity: Major
        Found in hierogolyph_benchmark_test.go and 1 other location - About 3 hrs to fix
        hierogolyph_benchmark_test.go on lines 99..129

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 301.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status