Sign upLogin

eventmachine/eventmachine

View on GitHub
Star
lib/em/connection.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Connection has 47 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Connection
    # @private
    attr_accessor :signature

    # @private
Severity: Minor
Found in lib/em/connection.rb - About 6 hrs to fix

    Method start_tls has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        def start_tls args={}
      priv_key_path   = args[:private_key_file]
      priv_key        = args[:private_key]
      priv_key_pass   = args[:private_key_pass]
      cert_chain_path = args[:cert_chain_file]
    Severity: Minor
    Found in lib/em/connection.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method start_tls has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def start_tls args={}
      priv_key_path   = args[:private_key_file]
      priv_key        = args[:private_key]
      priv_key_pass   = args[:private_key_pass]
      cert_chain_path = args[:cert_chain_file]
    Severity: Major
    Found in lib/em/connection.rb - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status