Sign upLogin

eventmachine/eventmachine

View on GitHub
Star
lib/em/protocols/linetext2.rb

Summary

Maintainability
C
1 day
Test Coverage

Method receive_data has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

      def receive_data data
        return unless (data and data.length > 0)

        # Do this stuff in lieu of a constructor.
        @lt2_mode ||= :lines
Severity: Minor
Found in lib/em/protocols/linetext2.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method receive_data has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def receive_data data
        return unless (data and data.length > 0)

        # Do this stuff in lieu of a constructor.
        @lt2_mode ||= :lines
Severity: Minor
Found in lib/em/protocols/linetext2.rb - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                  will_take = if remaining_data.length > needed
                            needed
                          else
                            remaining_data.length
                          end
    Severity: Major
    Found in lib/em/protocols/linetext2.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                    if @lt2_textpos >= @lt2_textsize
                # Reset line mode (the default behavior) BEFORE calling the
                # receive_binary_data. This makes it possible for user code
                # to call set_text_mode, enabling chains of text blocks
                # (which can possibly be of different sizes).
      Severity: Major
      Found in lib/em/protocols/linetext2.rb - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status