Sign upLogin

eventmachine/eventmachine

View on GitHub
Star
lib/em/protocols/saslauth.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method receive_data has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def receive_data data
        @sasl_data << data
        while @sasl_data.length >= 2
          len = (@sasl_data[0,2].unpack("n")).first
          raise "SASL Max Field Length exceeded" if len > MaxFieldSize
Severity: Minor
Found in lib/em/protocols/saslauth.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method receive_data has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def receive_data data
        @sasl_data << data

        while @sasl_data.length > 2
          len = (@sasl_data[0,2].unpack("n")).first
Severity: Minor
Found in lib/em/protocols/saslauth.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status