Sign upLogin

eventmachine/eventmachine

View on GitHub
Star
lib/em/protocols/stomp.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method consume_line has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        def consume_line line
          if @state == :precommand
            unless line =~ /\A\s*\Z/
              @command = line
              @state = :headers
Severity: Minor
Found in lib/em/protocols/stomp.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method consume_line has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def consume_line line
          if @state == :precommand
            unless line =~ /\A\s*\Z/
              @command = line
              @state = :headers
Severity: Minor
Found in lib/em/protocols/stomp.rb - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                  if k == "content-length"
                @content_length = v.to_i
              end
    Severity: Major
    Found in lib/em/protocols/stomp.rb - About 45 mins to fix

      Method receive_line has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def receive_line line
        @stomp_initialized || init_message_reader
        @stomp_message.consume_line(line) {|outcome|
          if outcome.first == :sized_text
            set_text_mode outcome[1]
      Severity: Minor
      Found in lib/em/protocols/stomp.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status