Showing 57 of 57 total issues
Avoid using static access to class '\Jose\Component\Core\JWKSet' in method 'verifyToken'. Open
$jwk_sets = JWKSet::createFromKeyData($sets);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$uri'. Open
public function forget(string $uri, string $query = '')- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid using static access to class '\Seat\Eseye\Configuration' in method '__construct'. Open
$configuration = Configuration::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$query'. Open
public function get(string $uri, string $query = '')- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid assigning values to variables in if clauses and the like (line '247', column '13'). Open
public function invoke(string $method, string $uri, array $uri_data = []): EsiResponse
{
// Check the Access Requirement
if (! $this->getAccessChecker()->can(- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class '\GuzzleHttp\Psr7\Uri' in method 'buildDataUri'. Open
return Uri::fromParts([
'scheme' => $this->getConfiguration()->esi_scheme,
'host' => $this->getConfiguration()->esi_host,
'port' => $this->getConfiguration()->esi_port,
'path' => rtrim($this->getVersion(), '/') .- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The function new_login() has 142 lines of code. Current threshold is set to 100. Avoid really long methods. Open
function new_login()
{
$action = $_SERVER['PHP_SELF'] . '?action=submitsecrets';
$callback = get_sso_callback_url();- Exclude checks
Avoid unused parameters such as '$query'. Open
public function set(string $uri, string $query, EsiResponse $data)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid using static access to class '\Seat\Eseye\Configuration' in method '__construct'. Open
$configuration = Configuration::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
get_sso_callback_url accesses the super-global variable $_SERVER. Open
function get_sso_callback_url()
{
if (! empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off')
$protocol = 'https://';- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
redirect_to_new accesses the super-global variable $_SERVER. Open
function redirect_to_new()
{
header('Location: ' . $_SERVER['PHP_SELF'] . '?action=new');
exit;- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
print_tokens accesses the super-global variable $_SERVER. Open
function print_tokens($access_token, $refresh_token)
{
$start_again_url = $_SERVER['PHP_SELF'] . '?action=new';
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
get_sso_callback_url accesses the super-global variable $_SERVER. Open
function get_sso_callback_url()
{
if (! empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off')
$protocol = 'https://';- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
The method invoke() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open
public function invoke(string $method, string $uri, array $uri_data = []): EsiResponse
{
// Check the Access Requirement
if (! $this->getAccessChecker()->can(- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
get_sso_callback_url accesses the super-global variable $_SERVER. Open
function get_sso_callback_url()
{
if (! empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off')
$protocol = 'https://';- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
get_sso_callback_url accesses the super-global variable $_SERVER. Open
function get_sso_callback_url()
{
if (! empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off')
$protocol = 'https://';- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
new_login accesses the super-global variable $_SERVER. Open
function new_login()
{
$action = $_SERVER['PHP_SELF'] . '?action=submitsecrets';
$callback = get_sso_callback_url();- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}