Sign upLogin

eveseat/eveapi

View on GitHub
Star

Showing 440 of 440 total issues

The method find_nearest_celestial is not named in camelCase.
Open

    public function find_nearest_celestial(int $solar_system_id, float $x, float $y, float $z, ?int $group = null): array
    {

        // Querying mapDenormalized with [1] we can see
        // the available different group types in the
Severity: Minor
Found in src/Traits/Utils.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method solar_system is not named in camelCase.
Open

    public function solar_system()
    {
        return $this->hasOne(SolarSystem::class, 'system_id', 'solar_system_id');
    }
Severity: Minor
Found in src/Models/Industry/CharacterMining.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method loyalty_points is not named in camelCase.
Open

    public function loyalty_points()
    {
        return $this->belongsToMany(CorporationInfo::class, 'character_loyalty_points', 'character_id', 'corporation_id')
            ->using(CharacterLoyaltyPoints::class)
            ->withPivot('amount')
Severity: Minor
Found in src/Models/Character/CharacterInfo.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method check_debug is not named in camelCase.
Open

    public function check_debug()
    {
        $this->line(' * Checking DEBUG mode');

        if (config('app.debug', false) == true)
Severity: Minor
Found in src/Commands/Seat/Admin/Diagnose.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method solar_system is not named in camelCase.
Open

    public function solar_system()
    {
        return $this->belongsTo(SolarSystem::class, 'system_id', 'system_id');
    }
Severity: Minor
Found in src/Models/PlanetaryInteraction/CorporationCustomsOffice.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method solar_system is not named in camelCase.
Open

    public function solar_system()
    {
        return $this->belongsTo(SolarSystem::class, 'system_id', 'system_id');
    }
Severity: Minor
Found in src/Models/Sde/Moon.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method check_database is not named in camelCase.
Open

    public function check_database()
    {
        $this->line(' * Checking Database');
        $this->table(['Setting', 'Value'], [
            ['Connection', config('database.default', 'mysql')],
Severity: Minor
Found in src/Commands/Seat/Admin/Diagnose.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method check_redis is not named in camelCase.
Open

    public function check_redis()
    {
        $this->line(' * Checking Redis');
        $this->table(['Setting', 'Value'], [
            ['Host', config('database.redis.default.host')],
Severity: Minor
Found in src/Commands/Seat/Admin/Diagnose.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method solar_system is not named in camelCase.
Open

    public function solar_system()
    {
        return $this->hasOne(SolarSystem::class, 'system_id', 'system_id')
            ->withDefault();
    }
Severity: Minor
Found in src/Models/Market/MarketOrder.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method contact_labels is not named in camelCase.
Open

    public function contact_labels()
    {

        return $this->hasMany(CharacterLabel::class,
            'character_id', 'character_id');
Severity: Minor
Found in src/Models/Character/CharacterInfo.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method corporation_roles is not named in camelCase.
Open

    public function corporation_roles()
    {

        return $this->hasMany(CharacterRole::class,
            'character_id', 'character_id');
Severity: Minor
Found in src/Models/Character/CharacterInfo.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method solar_system is not named in camelCase.
Open

    public function solar_system()
    {
        return $this->belongsTo(SolarSystem::class, 'solar_system_id', 'system_id');
    }
Severity: Minor
Found in src/Models/Location/CharacterLocation.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method cleanup_corps is not named in camelCase.
Open

    private function cleanup_corps()
    {

        // Need to find all corps that dont have a reason to be kept (no chars with tokens and not part of an alliance that has an active member)
        Alliance::doesntHave('corporations.characters.refresh_token')->each(function ($alliance) {
Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method cleanup_characters is not named in camelCase.
Open

    private function cleanup_characters()
    {
        CharacterInfo::doesntHave('refresh_token')->delete();
    }
Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method solar_system is not named in camelCase.
Open

    public function solar_system()
    {
        return $this->belongsTo(SolarSystem::class, 'solar_system_id', 'system_id')
            ->withDefault();
    }
Severity: Minor
Found in src/Models/PlanetaryInteraction/CharacterPlanet.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method wallet_transactions is not named in camelCase.
Open

    public function wallet_transactions()
    {

        return $this->hasMany(CharacterWalletTransaction::class,
            'character_id', 'character_id');
Severity: Minor
Found in src/Models/Character/CharacterInfo.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method token_schedule is not named in camelCase.
Open

    public function token_schedule()
    {
        return $this->hasOne(RefreshTokenSchedule::class, 'character_id');
    }
Severity: Minor
Found in src/Models/RefreshToken.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

TODO found
Open

     * TODO: Add a local override property as this scope
Severity: Minor
Found in src/Jobs/Corporation/Medals.php by fixme

TODO found
Open

     * TODO: Add a local scope override as this is diff.
Severity: Minor
Found in src/Jobs/Industry/Corporation/Mining/Observers.php by fixme

TODO found
Open

     * TODO: Why do we have this as a separate call?
Severity: Minor
Found in src/Jobs/Calendar/Attendees.php by fixme
Severity
Category
Status
Source
Language