Sign upLogin

eveseat/eveapi

View on GitHub
Star
src/Bus/Character.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method fire has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fire(): void
    {
        $this->addPublicJobs();

        if (! is_null($this->token))
Severity: Minor
Found in src/Bus/Character.php - About 1 hr to fix

    Method addAuthenticatedJobs has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function addAuthenticatedJobs()
    {
        $this->addAuthenticatedJob(new Roles($this->token));
        $this->addAuthenticatedJob(new Titles($this->token));
        $this->addAuthenticatedJob(new Clones($this->token));
    Severity: Minor
    Found in src/Bus/Character.php - About 1 hr to fix

      The class Character has a coupling between objects value of 45. Consider to reduce the number of dependencies under 13.
      Open

      class Character extends Bus
{
    /**
     * @var int
     */
      Severity: Minor
      Found in src/Bus/Character.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterInfo' in method 'fire'.
      Open

              $character = CharacterInfo::firstOrNew(
            ['character_id' => $this->character_id],
            ['name' => "Unknown Character : {$this->character_id}"]
        );
      Severity: Minor
      Found in src/Bus/Character.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      There are no issues that match your filters.

      Category
      Status