Sign upLogin

eveseat/eveapi

View on GitHub
Star
src/Bus/Corporation.php

Summary

Maintainability
C
1 day
Test Coverage

Method fire has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fire(): void
    {
        $this->addPublicJobs();

        if (! is_null($this->token))
Severity: Minor
Found in src/Bus/Corporation.php - About 1 hr to fix

    Method addAuthenticatedJobs has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function addAuthenticatedJobs()
    {
        $this->addAuthenticatedJob(new Divisions($this->corporation_id, $this->token));

        $this->addAuthenticatedJob(new Roles($this->corporation_id, $this->token));
    Severity: Minor
    Found in src/Bus/Corporation.php - About 1 hr to fix

      The class Corporation has a coupling between objects value of 41. Consider to reduce the number of dependencies under 13.
      Open

      class Corporation extends Bus
{
    /**
     * @var int
     */
      Severity: Minor
      Found in src/Bus/Corporation.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationInfo' in method 'fire'.
      Open

              $corporation = CorporationInfo::firstOrNew(
            ['corporation_id' => $this->corporation_id],
            ['name' => "Unknown Corporation: {$this->corporation_id}"]
        );
      Severity: Minor
      Found in src/Bus/Corporation.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              $batch = \Illuminate\Support\Facades\Bus::batch([$this->jobs->toArray()])
            ->then(function (Batch $batch) {
                logger()->debug(
                    sprintf('[Batches][%s] Corporation batch successfully completed.', $batch->id),
                    [
      Severity: Major
      Found in src/Bus/Corporation.php and 1 other location - About 1 day to fix
      src/Bus/Alliance.php on lines 76..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 274.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status