Sign upLogin

eveseat/eveapi

View on GitHub
Star
src/Commands/Esi/Job/Dispatch.php

Summary

Maintainability
A
2 hrs
Test Coverage

Avoid too many return statements within this method.
Open

                return $this->handleGenericJobs($class);
Severity: Major
Found in src/Commands/Esi/Job/Dispatch.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return $this->handlePublicCorporationJobs($class);
    Severity: Major
    Found in src/Commands/Esi/Job/Dispatch.php - About 30 mins to fix

      Avoid using static access to class '\Seat\Eveapi\Models\RefreshToken' in method 'handlePrivateCharacterJobs'.
      Open

              $refresh_token = RefreshToken::findOrFail($this->option('character_id'));
      Severity: Minor
      Found in src/Commands/Esi/Job/Dispatch.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method handlePublicCorporationJobs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $job::dispatch($this->option('corporation_id'));
        }
      Severity: Minor
      Found in src/Commands/Esi/Job/Dispatch.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\Seat\Eveapi\Models\RefreshToken' in method 'handlePrivateCorporationJobs'.
      Open

              $refresh_token = RefreshToken::findOrFail($this->option('character_id'));
      Severity: Minor
      Found in src/Commands/Esi/Job/Dispatch.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method handlePublicCharacterJobs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $job::dispatch($this->option('character_id'));
        }
      Severity: Minor
      Found in src/Commands/Esi/Job/Dispatch.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method handlePrivateCorporationJobs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $job::dispatch($this->option('corporation_id'), $refresh_token);
        }
      Severity: Minor
      Found in src/Commands/Esi/Job/Dispatch.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method handleGenericJobs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $job::dispatch();
        }
      Severity: Minor
      Found in src/Commands/Esi/Job/Dispatch.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method handlePrivateCharacterJobs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $job::dispatch($refresh_token);
        }
      Severity: Minor
      Found in src/Commands/Esi/Job/Dispatch.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function handlePublicCharacterJobs(string $job): int
    {
        if (! $this->option('character_id')) {
            $this->error('Missing mandatory character_id for an authenticated character job!');
      Severity: Minor
      Found in src/Commands/Esi/Job/Dispatch.php and 1 other location - About 40 mins to fix
      src/Commands/Esi/Job/Dispatch.php on lines 121..138

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function handlePublicCorporationJobs(string $job): int
    {
        if (! $this->option('corporation_id')) {
            $this->error('Missing mandatory corporation_id for an authenticated corporation job!');
      Severity: Minor
      Found in src/Commands/Esi/Job/Dispatch.php and 1 other location - About 40 mins to fix
      src/Commands/Esi/Job/Dispatch.php on lines 81..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status