Sign upLogin

eveseat/eveapi

View on GitHub
Star
src/Commands/Esi/Update/Killmails.php

Summary

Maintainability
A
1 hr
Test Coverage

Method handle has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        // collect optional kills ID from arguments
        $killmail_ids = $this->argument('killmail_ids') ?: [];
Severity: Minor
Found in src/Commands/Esi/Update/Killmails.php - About 1 hr to fix

    Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterInfo' in method 'handle'.
    Open

                        $character = CharacterInfo::firstOrNew(
                        ['character_id' => $token->character_id],
                        ['name' => "Unknown Character : {$token->character_id}"]
                    );
    Severity: Minor
    Found in src/Commands/Esi/Update/Killmails.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Seat\Eveapi\Models\Killmails\Killmail' in method 'handle'.
    Open

            $killmails = Killmail::whereDoesntHave('detail');
    Severity: Minor
    Found in src/Commands/Esi/Update/Killmails.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationInfo' in method 'handle'.
    Open

                    $corporation = CorporationInfo::firstOrNew(
                    ['corporation_id' => $token->character->affiliation->corporation_id],
                    ['name' => "Unknown Corporation : {$token->character->affiliation->corporation_id}"]
                );
    Severity: Minor
    Found in src/Commands/Esi/Update/Killmails.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Seat\Eveapi\Models\RefreshToken' in method 'handle'.
    Open

                RefreshToken::chunk(100, function ($tokens) {
                $tokens->each(function ($token) {
                    $character = CharacterInfo::firstOrNew(
                        ['character_id' => $token->character_id],
                        ['name' => "Unknown Character : {$token->character_id}"]
    Severity: Minor
    Found in src/Commands/Esi/Update/Killmails.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status