Sign upLogin

eveseat/eveapi

View on GitHub
Star
src/Commands/Eve/Update/Sde.php

Summary

Maintainability
C
1 day
Test Coverage

Method handle has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {

        // Start by warning the user about the command that will be run
        $this->comment('Warning! This Laravel command uses exec() to execute a ');
Severity: Major
Found in src/Commands/Eve/Update/Sde.php - About 3 hrs to fix

    File Sde.php has 307 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/*
 * This file is part of SeAT
 *
    Severity: Minor
    Found in src/Commands/Eve/Update/Sde.php - About 3 hrs to fix

      Function handle has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function handle()
    {

        // Start by warning the user about the command that will be run
        $this->comment('Warning! This Laravel command uses exec() to execute a ');
      Severity: Minor
      Found in src/Commands/Eve/Update/Sde.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method explodeMap has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function explodeMap()
    {
        // extract regions
        DB::table('regions')->truncate();
        DB::table('regions')
      Severity: Minor
      Found in src/Commands/Eve/Update/Sde.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                    return $this::INVALID;
        Severity: Major
        Found in src/Commands/Eve/Update/Sde.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $this::SUCCESS;
          Severity: Major
          Found in src/Commands/Eve/Update/Sde.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $this::SUCCESS;
            Severity: Major
            Found in src/Commands/Eve/Update/Sde.php - About 30 mins to fix

              Function importMysqlSde has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function importMysqlSde()
    {
        $bar = $this->getProgressBar(count($this->json->tables));

        foreach ($this->json->tables as $table) {
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              The method handle() has 147 lines of code. Current threshold is set to 100. Avoid really long methods.
              Open

                  public function handle()
    {

        // Start by warning the user about the command that will be run
        $this->comment('Warning! This Laravel command uses exec() to execute a ');
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              The method handle() has an NPath complexity of 6912. The configured NPath complexity threshold is 200.
              Open

                  public function handle()
    {

        // Start by warning the user about the command that will be run
        $this->comment('Warning! This Laravel command uses exec() to execute a ');
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              NPathComplexity

              Since: 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example

              class Foo {
    function bar() {
        // lots of complicated code
    }
}

              Source https://phpmd.org/rules/codesize.html#npathcomplexity

              The method handle() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
              Open

                  public function handle()
    {

        // Start by warning the user about the command that will be run
        $this->comment('Warning! This Laravel command uses exec() to execute a ');
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              Avoid using static access to class '\Seat\Services\Settings\Seat' in method 'handle'.
              Open

                      Seat::set('installed_sde', $this->json->version);
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'importPgSqlSde'.
              Open

                      DB::statement('CREATE ROLE yaml WITH NOLOGIN NOSUPERUSER NOCREATEDB NOCREATEROLE INHERIT NOREPLICATION CONNECTION LIMIT -1');
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'isStorageOk'.
              Open

                              File::makeDirectory($storage, 0755, true);
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'importPgSqlSde'.
              Open

                      DB::statement('GRANT yaml TO seat');
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'handle'.
              Open

                          if(! Schema::hasTable($table)) {
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'isStorageOk'.
              Open

                      if (File::isWritable(storage_path())) {
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method handle uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {

                $this->warn('Unable to determine the version number override. ' .
                    'Using remote version: ' . $this->json->version);
            }
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'importMysqlSde'.
              Open

                          if (! File::exists($archive_path)) {
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'importPgSqlSde'.
              Open

                          DB::statement('DROP OWNED BY yaml CASCADE');
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'importPgSqlSde'.
              Open

                      DB::statement('DROP ROLE IF EXISTS yaml');
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Seat\Services\Settings\Seat' in method 'handle'.
              Open

                      if ($this->json->version == Seat::get('installed_sde') &&
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'isStorageOk'.
              Open

                          if (! File::exists($storage))
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid excessively long variable names like $extracted_target_path. Keep variable name length under 20.
              Open

                  private function uncompressFile($archive_path, $extracted_target_path): void
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php by phpmd

              LongVariable

              Since: 0.2

              Detects when a field, formal or local variable is declared with a long name.

              Example

              class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

              Source https://phpmd.org/rules/naming.html#longvariable

              There are no issues that match your filters.

              Category
              Status