eveseat/eveapi

View on GitHub
src/Jobs/Contracts/Corporation/Contracts.php

Summary

Maintainability
A
1 hr
Test Coverage

Method handle has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        $structure_batch = new StructureBatch();

        while (true) {
Severity: Minor
Found in src/Jobs/Contracts/Corporation/Contracts.php - About 1 hr to fix

    The method handle() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
    Open

        public function handle()
        {
            $structure_batch = new StructureBatch();
    
            while (true) {

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid using static access to class '\Seat\Eveapi\Models\Contracts\ContractDetail' in method 'handle'.
    Open

                    $model = ContractDetail::firstOrNew([
                        'contract_id' => $contract->contract_id,
                    ]);

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Seat\Eveapi\Models\Contracts\CorporationContract' in method 'handle'.
    Open

                    CorporationContract::firstOrCreate([
                        'corporation_id' => $this->getCorporationId(),
                        'contract_id' => $contract->contract_id,
                    ]);

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status