src/Jobs/Corporation/Standings.php
Avoid unused parameters such as '$key'. Open
Open
$records = $chunk->map(function ($standing, $key) {- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationStanding' in method 'handle'. Open
Open
CorporationStanding::upsert($records->toArray(), [
'corporation_id',
'from_id',
]);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}