Method handle has 60 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle()
{
parent::handle();
while (true) {The method handle uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// If no services are defined on this structure, remove all of the
// ones we might have in the database.
CorporationStructureService::where('structure_id', $structure->structure_id)- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\Seat\Eveapi\Models\Universe\UniverseStructure' in method 'handle'. Open
$model = UniverseStructure::firstOrNew([
'structure_id' => $structure->structure_id,
]);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationStructure' in method 'handle'. Open
$model = CorporationStructure::firstOrNew([
'structure_id' => $structure->structure_id,
]);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}