Sign upLogin

eveseat/eveapi

View on GitHub
Star
src/Jobs/Killmails/Detail.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method handle has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        $response = $this->retrieve([
            'killmail_id' => $this->killmail_id,
            'killmail_hash' => $this->killmail_hash,
Severity: Major
Found in src/Jobs/Killmails/Detail.php - About 2 hrs to fix

    The method handle() has an NPath complexity of 320. The configured NPath complexity threshold is 200.
    Open

        public function handle()
    {
        $response = $this->retrieve([
            'killmail_id' => $this->killmail_id,
            'killmail_hash' => $this->killmail_hash,
    Severity: Minor
    Found in src/Jobs/Killmails/Detail.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method handle() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function handle()
    {
        $response = $this->retrieve([
            'killmail_id' => $this->killmail_id,
            'killmail_hash' => $this->killmail_hash,
    Severity: Minor
    Found in src/Jobs/Killmails/Detail.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid using static access to class '\Seat\Eveapi\Models\Killmails\KillmailVictim' in method 'handle'.
    Open

            $victim = KillmailVictim::firstOrNew([
            'killmail_id' => $this->killmail_id,
        ]);
    Severity: Minor
    Found in src/Jobs/Killmails/Detail.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Seat\Eveapi\Models\Killmails\KillmailDetail' in method 'handle'.
    Open

            $killmail = KillmailDetail::firstOrCreate([
            'killmail_id' => $this->killmail_id,
        ], [
            'killmail_time' => carbon($detail->killmail_time),
            'solar_system_id' => $detail->solar_system_id,
    Severity: Minor
    Found in src/Jobs/Killmails/Detail.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Seat\Eveapi\Models\Killmails\KillmailAttacker' in method 'handle'.
    Open

                $model = KillmailAttacker::firstOrNew([
                'killmail_id' => $this->killmail_id,
                'character_id' => property_exists($attacker, 'character_id') ?
                    $attacker->character_id : null,
                'corporation_id' => property_exists($attacker, 'corporation_id') ?
    Severity: Minor
    Found in src/Jobs/Killmails/Detail.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status