eveseat/eveapi

View on GitHub
src/Jobs/Maintenance.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Seat\Eveapi\Models\FailedJob' in method 'cleanup_tables'.
Open

        FailedJob::where('id', '<', FailedJob::max('id') - 100)->delete();
Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'cleanup_tables'.
Open

        DB::statement('OPTIMIZE TABLE failed_jobs, server_status, esi_status');
Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'cleanup_tables'.
Open

        DB::statement('OPTIMIZE TABLE character_assets, character_fitting_items, character_wallet_journals, character_wallet_transactions');
Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'cleanup_tables'.
Open

        DB::statement('OPTIMIZE TABLE contract_details, contract_items');
Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method cleanup_tables is not named in camelCase.
Open

    public function cleanup_tables()
    {

        logger()->info('[Cli] Performing tables maintenance');

Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method cleanup_corps is not named in camelCase.
Open

    private function cleanup_corps()
    {

        // Need to find all corps that dont have a reason to be kept (no chars with tokens and not part of an alliance that has an active member)
        Alliance::doesntHave('corporations.characters.refresh_token')->each(function ($alliance) {
Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method cleanup_characters is not named in camelCase.
Open

    private function cleanup_characters()
    {
        CharacterInfo::doesntHave('refresh_token')->delete();
    }
Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status