Sign upLogin

eveseat/eveapi

View on GitHub
Star
src/Jobs/Market/History.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method handle has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        if ($this->batchId && $this->batch()->cancelled()) {
            logger()->debug(sprintf('[Jobs][%s] Orders - Cancelling job due to relevant batch %s cancellation.', $this->job->getJobId(), $this->batch()->id));
Severity: Major
Found in src/Jobs/Market/History.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

                    return;
    Severity: Major
    Found in src/Jobs/Market/History.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return true;
      Severity: Major
      Found in src/Jobs/Market/History.php - About 30 mins to fix

        The method handle() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
        Open

            public function handle()
    {
        if ($this->batchId && $this->batch()->cancelled()) {
            logger()->debug(sprintf('[Jobs][%s] Orders - Cancelling job due to relevant batch %s cancellation.', $this->job->getJobId(), $this->batch()->id));
        Severity: Minor
        Found in src/Jobs/Market/History.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Avoid using static access to class '\Seat\Eveapi\Models\Market\Price' in method 'handle'.
        Open

                            Price::updateOrCreate([
                        'type_id' => $type_id,
                    ], [
                        'average' => $price->average,
                        'highest' => $price->highest,
        Severity: Minor
        Found in src/Jobs/Market/History.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method handle uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                                } else {
                            // Rethrow exception for any other status code
                            throw $e;
                        }
        Severity: Minor
        Found in src/Jobs/Market/History.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid using Seat\Eveapi\Jobs\Market\count() function in while loops.
        Open

                while(count($this->type_ids) > 0) {
            $delay = Redis::throttle('market-history-throttle')->block(0)->allow(self::ENDPOINT_RATE_LIMIT_CALLS)->every(self::ENDPOINT_RATE_LIMIT_WINDOW)->then(function () use ($region_id) {
                logger()->debug(sprintf('[Jobs][%s] History processing -> Remaining types: %d.', $this->job->getJobId(), count($this->type_ids)));

                $type_id = array_shift($this->type_ids);
        Severity: Minor
        Found in src/Jobs/Market/History.php by phpmd

        CountInLoopExpression

        Since: 2.7.0

        Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

        Example

        class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

        Source https://phpmd.org/rules/design.html#countinloopexpression

        There are no issues that match your filters.

        Category
        Status