src/Jobs/Market/OrderAggregates.php
Method handle has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function handle()
{
// the time only needs to be loaded once instead of every time in the loop
$now = carbon();
Avoid using static access to class '\Seat\Eveapi\Models\Market\Price' in method 'handle'. Open
Open
Price::upsert($types->toArray(),
[
'type_id',
'sell_price',
]- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Seat\Eveapi\Models\Market\Price' in method 'handle'. Open
Open
Price::upsert($types->toArray(),
[
'type_id',
'buy_price',
'updated_at',- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}