eveseat/eveapi

View on GitHub
src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php

Summary

Maintainability
C
1 day
Test Coverage

Method handle has 120 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        $response = $this->retrieve([
            'character_id' => $this->getCharacterId(),
            'planet_id' => $this->planet_id,
Severity: Major
Found in src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php - About 4 hrs to fix

    File PlanetDetail.php has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /*
     * This file is part of SeAT
     *
    Severity: Minor
    Found in src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php - About 2 hrs to fix

      The method handle() has 162 lines of code. Current threshold is set to 100. Avoid really long methods.
      Open

          public function handle()
          {
              $response = $this->retrieve([
                  'character_id' => $this->getCharacterId(),
                  'planet_id' => $this->planet_id,

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          private function cleanRoutes()
          {
              // retrieve all routes which have not been returned by API.
              // We will run a delete statement on those selected rows in order to avoid any deadlock.
              $existing_routes = CharacterPlanetRoute::where('character_id', $this->getCharacterId())
      Severity: Major
      Found in src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php and 3 other locations - About 1 hr to fix
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 431..444
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 449..462
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 467..480

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          private function cleanPins()
          {
              // retrieve all pins which have not been returned by API.
              // We will run a delete statement on those selected rows in order to avoid any deadlock.
              $existing_pins = CharacterPlanetPin::where('character_id', $this->getCharacterId())
      Severity: Major
      Found in src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php and 3 other locations - About 1 hr to fix
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 361..374
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 431..444
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 449..462

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          private function cleanExtractors()
          {
              // retrieve all extractors which have not been returned by API.
              // We will run a delete statement on those selected rows in order to avoid any deadlock.
              $existing_extractors = CharacterPlanetExtractor::where('character_id', $this->getCharacterId())
      Severity: Major
      Found in src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php and 3 other locations - About 1 hr to fix
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 361..374
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 449..462
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 467..480

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          private function cleanFactories()
          {
              // retrieve all factories which have not been returned by API.
              // We will run a delete statement on those selected rows in order to avoid any deadlock.
              $existing_factories = CharacterPlanetFactory::where('character_id', $this->getCharacterId())
      Severity: Major
      Found in src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php and 3 other locations - About 1 hr to fix
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 361..374
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 431..444
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 467..480

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function cleanLinks()
          {
              // retrieve all links which have not been returned by API.
              // We will run a delete statement on those selected rows in order to avoid any deadlock.
              $this->planet_links->groupBy('source_pin_id')->each(function ($links) {
      Severity: Minor
      Found in src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php and 1 other location - About 50 mins to fix
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 343..356

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function cleanRouteWaypoints()
          {
              // retrieve all waypoints which have not been returned by API.
              // We will run a delete statement on those selected rows in order to avoid any deadlock.
              $this->planet_waypoints->groupBy('route_id')->each(function ($pins) {
      Severity: Minor
      Found in src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php and 1 other location - About 50 mins to fix
      src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php on lines 379..392

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status