eveseat/eveapi

View on GitHub
src/Traits/IsReadOnly.php

Summary

Maintainability
A
0 mins
Test Coverage

The method bypassReadOnly has a boolean flag argument $new_value, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function bypassReadOnly(bool $new_value = true)
Severity: Minor
Found in src/Traits/IsReadOnly.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid unused parameters such as '$new_value'.
Open

    public function bypassReadOnly(bool $new_value = true)
Severity: Minor
Found in src/Traits/IsReadOnly.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

There are no issues that match your filters.

Category
Status