Sign upLogin

eveseat/eveapi

View on GitHub
Star
src/Traits/Utils.php

Summary

Maintainability
A
1 hr
Test Coverage

Method find_nearest_celestial has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function find_nearest_celestial(int $solar_system_id, float $x, float $y, float $z, ?int $group = null): array
    {

        // Querying mapDenormalized with [1] we can see
        // the available different group types in the
Severity: Minor
Found in src/Traits/Utils.php - About 1 hr to fix

    Method find_nearest_celestial has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function find_nearest_celestial(int $solar_system_id, float $x, float $y, float $z, ?int $group = null): array
    Severity: Minor
    Found in src/Traits/Utils.php - About 35 mins to fix

      Avoid variables with short names like $z. Configured minimum length is 3.
      Open

          public function find_nearest_celestial(int $solar_system_id, float $x, float $y, float $z, ?int $group = null): array
      Severity: Minor
      Found in src/Traits/Utils.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $y. Configured minimum length is 3.
      Open

          public function find_nearest_celestial(int $solar_system_id, float $x, float $y, float $z, ?int $group = null): array
      Severity: Minor
      Found in src/Traits/Utils.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $x. Configured minimum length is 3.
      Open

          public function find_nearest_celestial(int $solar_system_id, float $x, float $y, float $z, ?int $group = null): array
      Severity: Minor
      Found in src/Traits/Utils.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      The method find_nearest_celestial is not named in camelCase.
      Open

          public function find_nearest_celestial(int $solar_system_id, float $x, float $y, float $z, ?int $group = null): array
    {

        // Querying mapDenormalized with [1] we can see
        // the available different group types in the
      Severity: Minor
      Found in src/Traits/Utils.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status