Sign upLogin

eveseat/notifications

View on GitHub
Star

Showing 405 of 405 total issues

Avoid unused parameters such as '$notifiable'.
Open

    public function toArray($notifiable)
Severity: Minor
Found in src/Notifications/Corporations/Mail/InActiveCorpMember.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationInfo' in method 'toSlack'.
Open

        $corporation = CorporationInfo::find($this->notification->text['corpID']);
Severity: Minor
Found in src/Notifications/Corporations/Slack/CharLeftCorpMsg.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Web\Models\User' in method '__construct'.
Open

        $this->user = User::find($member->user_id);
Severity: Minor
Found in src/Notifications/Seat/Mail/SquadMemberRemovedNotification.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$notifiable'.
Open

    public function toMail($notifiable)
Severity: Minor
Found in src/Notifications/Seat/Mail/SquadMemberRemovedNotification.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$notifiable'.
Open

    public function via($notifiable)
Severity: Minor
Found in src/Notifications/Seat/Slack/CreatedUser.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$notifiable'.
Open

    public function toSlack($notifiable)
Severity: Minor
Found in src/Notifications/Sovereignties/Slack/SovStructureDestroyed.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$notifiable'.
Open

    public function toMail($notifiable)
Severity: Minor
Found in src/Notifications/Starbases/Mail/StarbaseStateChange.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$notifiable'.
Open

    public function toArray($notifiable)
Severity: Minor
Found in src/Notifications/Starbases/Slack/StarbaseStateChange.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Seat\Eveapi\Models\Sde\InvType' in method 'toSlack'.
Open

                    $type = InvType::find($this->notification->text['structureTypeID']);
Severity: Minor
Found in src/Notifications/Structures/Slack/MoonMiningExtractionStarted.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$notifiable'.
Open

    public function via($notifiable)
Severity: Minor
Found in src/Notifications/Structures/Slack/OrbitalAttacked.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Seat\Eveapi\Models\Universe\UniverseName' in method 'toSlack'.
Open

                                (UniverseName::firstOrNew(
                                    ['entity_id' => $this->notification->text['aggressorCorpID']],
                                    ['category' => 'corporation', 'name' => trans('web::seat.unknown')])
Severity: Minor
Found in src/Notifications/Structures/Slack/OrbitalAttacked.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Universe\UniverseName' in method 'toSlack'.
Open

                    $old = UniverseName::firstOrNew(
                        ['entity_id' => $this->notification->text['oldOwnerCorpID']],
                        ['name' => trans('web::seat.unknown')]
                    );
Severity: Minor
Found in src/Notifications/Structures/Slack/OwnershipTransferred.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Sde\InvType' in method 'toSlack'.
Open

                    $type = InvType::firstOrNew(
                        ['typeID' => $this->notification->text['structureTypeID']],
                        ['typeName' => trans('web::seat.unknown')]
                    );
Severity: Minor
Found in src/Notifications/Structures/Slack/StructureLostArmor.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$notifiable'.
Open

    public function toSlack($notifiable)
Severity: Minor
Found in src/Notifications/Structures/Slack/StructureServicesOffline.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$notifiable'.
Open

    public function toSlack($notifiable)
Severity: Minor
Found in src/Notifications/Structures/Slack/StructureWentLowPower.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$notifiable'.
Open

    public function toSlack($notifiable)
Severity: Minor
Found in src/Notifications/Wars/Slack/AllWarDeclaredMsg.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Seat\Eveapi\Models\Universe\UniverseName' in method 'toSlack'.
Open

                        $entity = UniverseName::firstOrNew(
                            ['entity_id' => $this->notification->text['againstID']],
                            ['name' => trans('web::seat.unknown')]
                        );
Severity: Minor
Found in src/Notifications/Wars/Slack/AllWarDeclaredMsg.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method toSlack() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
Open

    public function toSlack($notifiable)
    {
        return (new SlackMessage)
            ->content('A structure is under attack!')
            ->from('SeAT Structure Monitor')
Severity: Minor
Found in src/Notifications/Structures/Slack/StructureUnderAttack.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method add_migrations is not named in camelCase.
Open

    private function add_migrations()
    {
        $this->loadMigrationsFrom(__DIR__ . '/database/migrations/');
    }
Severity: Minor
Found in src/NotificationsServiceProvider.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method add_alerts is not named in camelCase.
Open

    private function add_alerts()
    {
        $this->publishes([
            __DIR__ . '/Config/notifications.alerts.php' => config_path('notifications.alerts.php'),
        ], ['config', 'seat']);
Severity: Minor
Found in src/NotificationsServiceProvider.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language