Sign upLogin

eveseat/web

View on GitHub
Star
src/Http/Controllers/Corporation/StarbaseController.php

Summary

Maintainability
A
1 hr
Test Coverage

Method getStarbaseModules has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getStarbaseModules(int $corporation_id, int $starbase_id): Collection
    {

        // retrieving starbase location
        $starbase = CorporationStarbase::where('starbase_id', $starbase_id)
Severity: Minor
Found in src/Http/Controllers/Corporation/StarbaseController.php - About 1 hr to fix

    The method getStarbaseModules() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
    Open

        private function getStarbaseModules(int $corporation_id, int $starbase_id): Collection
    {

        // retrieving starbase location
        $starbase = CorporationStarbase::where('starbase_id', $starbase_id)
    Severity: Minor
    Found in src/Http/Controllers/Corporation/StarbaseController.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid unused parameters such as '$starbase_id'.
    Open

        private function getCorporationStarbases(int $corporation_id, ?int $starbase_id = null)
    Severity: Minor
    Found in src/Http/Controllers/Corporation/StarbaseController.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid excessively long variable names like $max_structure_distance. Keep variable name length under 20.
    Open

            $max_structure_distance = 0.0;
    Severity: Minor
    Found in src/Http/Controllers/Corporation/StarbaseController.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status