eveseat/web

Method postChangeCharacter has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function postChangeCharacter(Request $request)
    {
        $request->validate([
            'character_id' => 'integer|exists:character_infos,character_id|required',
        ]);

Method postUpdateSharelink has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function postUpdateSharelink(Sharelink $request)
    {
        // Validate our character id is valid for the submitting user
        if ((int) $request->input('user_sharelink_character_id') !== 0) {
            $requested_character = auth()->user()->characters->contains((int) $request->input('user_sharelink_character_id'));

Avoid using undefined variables such as '$options' which will lead to PHP notices.

Open

        $skins = Profile::$options['skins'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$options' which will lead to PHP notices.

Open

        $thousand = Profile::$options['thousand_seperator'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$options' which will lead to PHP notices.

Open

        $decimal = Profile::$options['decimal_seperator'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$options' which will lead to PHP notices.

Open

        $sidebar = Profile::$options['sidebar'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

The class ProfileController has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.

Open

class ProfileController extends Controller
{
    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The method getView uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $characters = auth()->user()->characters;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}