Sign upLogin

eveseat/web

View on GitHub
Star
src/Http/Controllers/Support/FastLookupController.php

Summary

Maintainability
F
3 days
Test Coverage

File FastLookupController.php has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Minor
Found in src/Http/Controllers/Support/FastLookupController.php - About 5 hrs to fix

    Method getEntities has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getEntities(Request $request)
    {

        $this->validate($request, [
            'type' => 'in:characters,corporations,alliances',
    Severity: Major
    Found in src/Http/Controllers/Support/FastLookupController.php - About 2 hrs to fix

      Method getUsers has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getUsers(Request $request)
    {
        $users = User::with('characters')
            ->standard()
            ->where('name', 'like', ["%{$request->query('q', '')}%"]);
      Severity: Minor
      Found in src/Http/Controllers/Support/FastLookupController.php - About 1 hr to fix

        Method getSystems has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getSystems(Request $request)
    {
        if ($request->query('_type', 'query') == 'find') {
            $system = SolarSystem::find($request->query('q', 0));
        Severity: Minor
        Found in src/Http/Controllers/Support/FastLookupController.php - About 1 hr to fix

          Function getEntities has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getEntities(Request $request)
    {

        $this->validate($request, [
            'type' => 'in:characters,corporations,alliances',
          Severity: Minor
          Found in src/Http/Controllers/Support/FastLookupController.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return response()->json([
            'results' => $scopes,
        ]);
          Severity: Major
          Found in src/Http/Controllers/Support/FastLookupController.php - About 30 mins to fix

            The method getEntities() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
            Open

                public function getEntities(Request $request)
    {

        $this->validate($request, [
            'type' => 'in:characters,corporations,alliances',
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            The class FastLookupController has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
            Open

            class FastLookupController extends Controller
{
    const SKILL_CATEGORY_ID = 16;

    /**
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

            CouplingBetweenObjects

            Since: 1.1.0

            A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

            Example

            class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

            Source https://phpmd.org/rules/design.html#couplingbetweenobjects

            Avoid unused parameters such as '$key'.
            Open

                        ->map(function ($corporation, $key) {
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$key'.
            Open

                        ->map(function ($item, $key) {
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$key'.
            Open

                        ->map(function ($skill, $key) {
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$key'.
            Open

                        ->map(function ($character, $key) {
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$key'.
            Open

                            $characters = $user->characters->sortBy(function ($character, $key) use ($user) {
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$key'.
            Open

                        ->map(function ($alliance, $key) {
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$key'.
            Open

                        'results' => $union->get()->map(function ($entity, $key) {
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function getCharacters(Request $request)
    {
        if ($request->query('_type', 'query') == 'find') {
            $character = CharacterInfo::find($request->query('q', 0));
            Severity: Major
            Found in src/Http/Controllers/Support/FastLookupController.php and 2 other locations - About 4 hrs to fix
            src/Http/Controllers/Support/FastLookupController.php on lines 173..198
            src/Http/Controllers/Support/FastLookupController.php on lines 204..229

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function getCorporations(Request $request)
    {
        if ($request->query('_type', 'query') == 'find') {
            $corporation = CorporationInfo::find($request->query('q', 0));
            Severity: Major
            Found in src/Http/Controllers/Support/FastLookupController.php and 2 other locations - About 4 hrs to fix
            src/Http/Controllers/Support/FastLookupController.php on lines 143..167
            src/Http/Controllers/Support/FastLookupController.php on lines 204..229

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function getAlliances(Request $request)
    {
        if ($request->query('_type', 'query') == 'find') {
            $alliance = Alliance::find($request->query('q', 0));
            Severity: Major
            Found in src/Http/Controllers/Support/FastLookupController.php and 2 other locations - About 4 hrs to fix
            src/Http/Controllers/Support/FastLookupController.php on lines 143..167
            src/Http/Controllers/Support/FastLookupController.php on lines 173..198

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if ($request->query('_type', 'query') == 'find') {
            $system = SolarSystem::find($request->query('q', 0));

            if (is_null($system)) {
                return response()->json();
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php and 2 other locations - About 30 mins to fix
            src/Http/Controllers/Support/FastLookupController.php on lines 386..397
            src/Http/Controllers/Support/FastLookupController.php on lines 421..432

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if ($request->query('_type', 'query') == 'find') {
            $constellation = Constellation::find($request->query('q', 0));

            if (is_null($constellation)) {
                return response()->json();
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php and 2 other locations - About 30 mins to fix
            src/Http/Controllers/Support/FastLookupController.php on lines 386..397
            src/Http/Controllers/Support/FastLookupController.php on lines 495..506

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if ($request->query('_type', 'query') == 'find') {
            $region = Region::find($request->query('q', 0));

            if (is_null($region)) {
                return response()->json();
            Severity: Minor
            Found in src/Http/Controllers/Support/FastLookupController.php and 2 other locations - About 30 mins to fix
            src/Http/Controllers/Support/FastLookupController.php on lines 421..432
            src/Http/Controllers/Support/FastLookupController.php on lines 495..506

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status