Sign upLogin

eveseat/web

View on GitHub
Star
src/Http/Controllers/Tools/MoonsController.php

Summary

Maintainability
A
1 hr
Test Coverage

Method store has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function store(ProbeReport $request)
    {
        $report = $request->input('moon-report');

        // enforce tabulation spacer
Severity: Minor
Found in src/Http/Controllers/Tools/MoonsController.php - About 1 hr to fix

    Function store has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function store(ProbeReport $request)
    {
        $report = $request->input('moon-report');

        // enforce tabulation spacer
    Severity: Minor
    Found in src/Http/Controllers/Tools/MoonsController.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The class MoonsController has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
    Open

    class MoonsController extends Controller
{
    /**
     * @param  \Seat\Web\Http\DataTables\Tools\MoonsDataTable  $dataTable
     * @return mixed
    Severity: Minor
    Found in src/Http/Controllers/Tools/MoonsController.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

        public function show(int $id)
    Severity: Minor
    Found in src/Http/Controllers/Tools/MoonsController.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status