Method getStandingsAjaxElementName has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getStandingsAjaxElementName(Request $request)
{
$response = [
'results' => [],Method postAddStandingsFromCorpOrChar has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function postAddStandingsFromCorpOrChar(StandingsExistingElementAdd $request)
{
// Get the standings profile that will be updated.
$standings_profile = StandingsProfile::find($request->input('id'));Function postAddStandingsFromCorpOrChar has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function postAddStandingsFromCorpOrChar(StandingsExistingElementAdd $request)
{
// Get the standings profile that will be updated.
$standings_profile = StandingsProfile::find($request->input('id'));- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getStandingsAjaxElementName has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function getStandingsAjaxElementName(Request $request)
{
$response = [
'results' => [],- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return response()->json($response);The class StandingsController has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13. Open
class StandingsController extends Controller
{
const ENTITY_CACHE_PREFIX = 'name_id';
/**- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Avoid assigning values to variables in if clauses and the like (line '142', column '29'). Open
public function getStandingsAjaxElementName(Request $request)
{
$response = [
'results' => [],- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using empty try-catch blocks in getStandingsAjaxElementName. Open
} catch (Exception $e) {
}- Read upRead up
- Exclude checks
EmptyCatchBlock
Since: 2.7.0
Usually empty try-catch is a bad idea because you are silently swallowing an error condition and then continuing execution. Occasionally this may be the right thing to do, but often it's a sign that a developer saw an exception, didn't know what to do about it, and so used an empty catch to silence the problem.
Example
class Foo {
public function bar()
{
try {
// ...
} catch (Exception $e) {} // empty catch block
}
}Source https://phpmd.org/rules/design.html#emptycatchblock
Avoid variables with short names like $id. Configured minimum length is 3. Open
public function getStandingEdit(int $id, StandingsDataTable $dataTable)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}